removed html_enc() from HTMLEntitiesEncode.pm fixes:#3563

[gautamkrishnar]

fixes:#3563

[GuiltyDolphin]

@gautamkrishnar Thanks!

[GuiltyDolphin]

@gautamkrishnar Whoops, look like we missed a few, mind making another PR (sorry about that)?

[gautamkrishnar]

@GuiltyDolphin can you please elaborate?

[gautamkrishnar]

What's missed ?

[GuiltyDolphin]

@gautamkrishnar There's a couple of html_enc calls still hanging around (do a quick grep).

[gautamkrishnar]

@GuiltyDolphin i left them untouched because this IA require html_enc to work. It is even comparing a value with the html_enc() function. Please check the code. If you are sure that it must be removed, i will open up annother pr.

[GuiltyDolphin]

@gautamkrishnar Ah, you are correct - this should be using an external library then (e.g., HTML::Entities) rather than html_enc which is designed for 'internal' use. This would help make it explicit that the encoding is for the IA's functionality rather than actual query/output encoding and remove the dependency on DDG.

Would you like to update the library usage?

[gautamkrishnar]

@GuiltyDolphin sure, i am having my eams this week. I will give it a try after that... 👍

Thanks 😄