Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Selenium white space triggering travis warning #4266

Merged
merged 1 commit into from Jun 9, 2017

Conversation

kirkins
Copy link
Contributor

@kirkins kirkins commented Jun 9, 2017

Description of new Instant Answer, or changes

# Testing selenium....................... 1 WARNING

# 	 -> WARN: Trailing whitespace in key 'driver.get('http://www.example.com') 

Related Issues and Discussions

People to notify

Testing & Review

To be completed by Community Leader (or DDG Staff) when reviewing Pull Request

Pull Request

  • Title follows correct format (Specifies Instant Answer + Purpose)
  • Description contains a valid Instant Answer Page Link (e.g. https://duck.co/ia/view/my_ia)

Instant Answer Page (for new Instant Answers)

  • Instant Answer page is correctly filled out and contains:
    • The Title is appropriately named and formatted
    • The IA topics are present and appropriate
    • The Description is clear and coherent
    • Source Name exists if applicable
    • All Example Queries trigger on Beta

Code

  • Adheres to the DuckDuckGo Style Guide
  • Behaviour is appropriately tested. If improvement, tests are adequately extended.
  • There is no unnecessary files in place (such as editor config files)
  • There is no API keys / secrets present
  • Tests are passing (run $ duckpan test <goodie_id>)
    • Tester should report any failures

Ready to merge?

  • Has this IA been deployed to and tested on beta.duckduckgo.com?
  • For larger commits, has this been approved be more than one community member?
  • The number of reviews is appropriate for this type of PR
  • The commit message is clear, coherent and fitting

Pull Request Review Guidelines: https://docs.duckduckhack.com/programming-mission/pr-review.html


Instant Answer Page: https://duck.co/ia/view/selenium

@daxtheduck
Copy link

daxtheduck commented Jun 9, 2017

Selenium

Description: Selenium is a set of different software tools each with a different approach to supporting test automation. The entire suite of tools results in a rich set of testing functions specifically geared to the needs of testing of web applications of all types.

Example Query: selenium cheat sheet

Tab Name: Cheat Sheet

Source: http://docs.seleniumhq.org/docs/

These are the important fields from the IA page. Please check these for errors or missing information and update the IA page


This is an automated message which will be updated as changes are made to the IA page

@kirkins
Copy link
Contributor Author

kirkins commented Jun 9, 2017

Another strange testing error. There is no way this should fail given it only removes a single white space which travis.cli was complaining about in the first place.

@kirkins
Copy link
Contributor Author

kirkins commented Jun 9, 2017

I've seen this line fail multiple times on several commits.

Not sure why, works fine when I run it manually on Codio.

@moollaza
Copy link
Member

moollaza commented Jun 9, 2017

I've seen this line fail multiple times on several commits.

Not sure why, works fine when I run it manually on Codio.

That's really odd -- that must be a problem on Travis end as duckpan.org hasn't had any problems.

@moollaza
Copy link
Member

moollaza commented Jun 9, 2017

There is no way this should fail given it only removes a single white space which travis.cli was complaining about in the first place.

@kirkins AFAIK those warnings don't cause the travis test to fail, that's why it reports it as a WARN. Can you show me where it caused a failure?

@moollaza moollaza merged commit 5213080 into duckduckgo:master Jun 9, 2017
@kirkins
Copy link
Contributor Author

kirkins commented Jun 9, 2017

@moollaza you're absolutely right, I'm just fixing the warning because I'm bored.

@kirkins
Copy link
Contributor Author

kirkins commented Jun 9, 2017

@moollaza I was saying the line that says:

- dzil authordeps | grep -ve '^\W' | xargs -n 5 -P 10 cpanm --quiet --notest --mirror http://www.cpan.org/ --mirror http://duckpan.org

In the travis.cli file seems to fail sometimes, as I've seen it fail a few times in cases where the tests just had to be re-run.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants