Adding Lowercase.pm #554

Merged
merged 5 commits into from Jul 19, 2014

Conversation

Projects
None yet
5 participants
@DavidMascio
Contributor

DavidMascio commented Jul 17, 2014

What does your instant answer do?
It transforms any string into all lowercase.

What problem does your instant answer solve (Why is it better than organic links)?

What is the data source for your instant answer? (Provide a link if possible)
N/A

What are some example queries that trigger this instant answer?
lowercase GitHub, lower case GitHub

Which communities will this instant answer be especially useful for? (gamers, book lovers, etc)
Anyone who can't turn Caps Lock off.

Is this instant answer connected to a DuckDuckHack instant answer idea?
"Converting uppercase to lowercase, and vice versa"

Which existing instant answers will this one supercede/overlap with?
As far as I know, none.

Are you having any problems? Do you need our help with anything?
Nope!

**Note: Please attach a screenshot for new instant answer pull requests, and for pull requests which modify the look/design of existing instant answers.

screenshot

Checklist

Please place an 'X' where appropriate.

[X] Added metadata and attribution information
[X] Wrote test file and added to t/ directory
[X] Verified that instant answer adheres to design guidelines(https://github.com/duckduckgo/duckduckgo-documentation/blob/master/duckduckhack/styleguides/design_styleguide.md)
[X] Tested cross-browser compatibility

    Please let us know which browsers/devices you've tested on:
    - Windows 8
        [X] Google Chrome   
        [X] Firefox         
        [X] Opera           
        [X] IE 10           

    - Windows 7
        [X] Google Chrome   
        [X] Firefox         
        [X] Opera           
        [X] IE 8            
        [X] IE 9            
        [X] IE 10           

    - Windows XP
        [] IE 7            
        [] IE 8            

    - Mac OSX
        [X] Google Chrome   
        [X] Firefox         
        [X] Opera           
        [X] Safari          

    - iOS (iPhone)
        [] Safari Mobile   
        [] Google Chrome   
        [] Opera           

    - iOS (iPad)
        [] Safari Mobile   
        [] Google Chrome   
        [] Opera            

    - Android
        [X] Firefox         
        [X] Native Browser  
        [X] Google Chrome   
        [X] Opera
t/Lowercase.t
+ test_zci('foo'),
+ 'lowercase john Doe' =>
+ test_zci('john doe'),
+);

This comment has been minimized.

Show comment Hide comment
@mintsoft

mintsoft Jul 17, 2014

Member

Can you add tests for the example queries?

Thanks,

@mintsoft

mintsoft Jul 17, 2014

Member

Can you add tests for the example queries?

Thanks,

lib/DDG/Goodie/Lowercase.pm
+zci is_cached => 1;
+zci answer_type => "lowercase";
+
+triggers start => 'lowercase', 'lower case';

This comment has been minimized.

Show comment Hide comment
@mintsoft

mintsoft Jul 17, 2014

Member

how about adding lc strtolower tolower

@mintsoft

mintsoft Jul 17, 2014

Member

how about adding lc strtolower tolower

@mintsoft

This comment has been minimized.

Show comment Hide comment
@mintsoft

mintsoft Jul 17, 2014

Member

Hi @DavidMascio

Thanks for doing this!

LGTM, just a few small things I've put against the commits.

Member

mintsoft commented Jul 17, 2014

Hi @DavidMascio

Thanks for doing this!

LGTM, just a few small things I've put against the commits.

@mintsoft

This comment has been minimized.

Show comment Hide comment
@mintsoft

mintsoft Jul 17, 2014

Member

@moollaza @jagtalon ping! Any additional feedback?

Member

mintsoft commented Jul 17, 2014

@moollaza @jagtalon ping! Any additional feedback?

@moollaza

This comment has been minimized.

Show comment Hide comment
@moollaza

moollaza Jul 19, 2014

Member

LGTM 👍 Congrats on your first Goodie @DavidMascio 😃

Member

moollaza commented Jul 19, 2014

LGTM 👍 Congrats on your first Goodie @DavidMascio 😃

moollaza added a commit that referenced this pull request Jul 19, 2014

@moollaza moollaza merged commit f40727f into duckduckgo:master Jul 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 21, 2014

Member

It didn't pass through QA! Sorry just got around to checking this. Would like to have this design https://duckduckgo.com/?q=convert+celsius+to+fahrenheit, but this is good for now.

@moollaza Please set up the release.

@DavidMascio Nice!

Member

jagtalon commented Jul 21, 2014

It didn't pass through QA! Sorry just got around to checking this. Would like to have this design https://duckduckgo.com/?q=convert+celsius+to+fahrenheit, but this is good for now.

@moollaza Please set up the release.

@DavidMascio Nice!

@mintsoft

This comment has been minimized.

Show comment Hide comment
@mintsoft

mintsoft Jul 21, 2014

Member

@jagtalon out of curiosity what are thinking design wise? Something like 'HelloWorld' in lowercase is 'helloworld' ?

Member

mintsoft commented Jul 21, 2014

@jagtalon out of curiosity what are thinking design wise? Something like 'HelloWorld' in lowercase is 'helloworld' ?

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 21, 2014

Member

@mintsoft Oh I just meant bigger fonts that's all. :)

Member

jagtalon commented Jul 21, 2014

@mintsoft Oh I just meant bigger fonts that's all. :)

@mintsoft

This comment has been minimized.

Show comment Hide comment
@mintsoft

mintsoft Jul 21, 2014

Member

@jagtalon oh right!

Member

mintsoft commented Jul 21, 2014

@jagtalon oh right!

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 21, 2014

Member

@mintsoft It's no problem, though. Let's just iterate on it.

Member

jagtalon commented Jul 21, 2014

@mintsoft It's no problem, though. Let's just iterate on it.

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 21, 2014

Member

But new stuff should go through QA (meaning @chrismorast @zekiel are mentioned, too)

Member

jagtalon commented Jul 21, 2014

But new stuff should go through QA (meaning @chrismorast @zekiel are mentioned, too)

@moollaza

This comment has been minimized.

Show comment Hide comment
@moollaza

moollaza Jul 22, 2014

Member

@jagtalon, @mintsoft, sorry guys, not sure what I was thinking with the quick merge

Member

moollaza commented Jul 22, 2014

@jagtalon, @mintsoft, sorry guys, not sure what I was thinking with the quick merge

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 23, 2014

Member

@moollaza That's cool. :) Please make a release.

Member

jagtalon commented Jul 23, 2014

@moollaza That's cool. :) Please make a release.

@chrismorast

This comment has been minimized.

Show comment Hide comment
@chrismorast

chrismorast Jul 23, 2014

Please update the font size before merging. I don't like having to revisit stuff if we don't have to.

Please update the font size before merging. I don't like having to revisit stuff if we don't have to.

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 29, 2014

Member

@DavidMascio Please increase the font-size like in https://duckduckgo.com/?q=1+%2B+1 or https://duckduckgo.com/?q=convert+celsius+to+fahrenheit so that we can release.

Member

jagtalon commented Jul 29, 2014

@DavidMascio Please increase the font-size like in https://duckduckgo.com/?q=1+%2B+1 or https://duckduckgo.com/?q=convert+celsius+to+fahrenheit so that we can release.

@moollaza

This comment has been minimized.

Show comment Hide comment
@moollaza

moollaza Jul 29, 2014

Member

@jagtalon I've already made a PR for that: #560

Member

moollaza commented Jul 29, 2014

@jagtalon I've already made a PR for that: #560

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jul 29, 2014

Member

@moollaza Oops, my bad!

Member

jagtalon commented Jul 29, 2014

@moollaza Oops, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment