Conversation
# Metadata. | ||
name "LOLCAT"; | ||
description "Convert text to LOLCAT language"; | ||
primary_example_queries "lolcat have cheeseburger"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you ensure there's a test for the primary_example_query
?
@JohnCarlosReed Thanks for the contribution! I've put some minor bits of feedback on for you. |
@mintsoft Thanks Rob. I've addressed your points. Could you please re-review whenever you get a chance? |
attribution github => ["JohnCarlosReed", "John Reed"], | ||
twitter => "johnnycarlos"; | ||
|
||
my %repl = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @mwmiller might suggest here that using some sort of JSON/YAML file that can be slurped would be the best way to build this kind of static hash.
That way it would be easier to read and update too imo. The 2 columns are a little funny.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively moving it below the handle
and switching to a single column might be just as good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively moving it below the handle and switching to a single column might be just as good.
I don't think that's quite as good. One supposed advantage of the serialized data files is that non-perl folks can see where and how to contribute.
This is a great candidate for one of the first auto-templated goodies. I am completely unable to find the documentation I created on this! Here's the short version. You need three bits of information. The operation you are performing ("LOLcat translation"), the input to the operation ("may I have a cheeseburger?") and the result of performing the operation ("I CAN HAZ CHEEZEBUGER?") Then, where you're returning the translate, you add a little magic to get a styled answer: my $input = $_;
return unless $input;
my $result = translate($input);
return $result, structured_answer => { input => [html_enc($input)], operation => 'LOLcat translation', result => html_enc($result); |
@JohnCarlosReed Hey, just catching up; are you OK to limit the output only if all the words can be converted as @moollaza agreed? Just ping if you need any help |
@JohnCarlosReed updates? here to help if you need anything. |
@JohnCarlosReed Any updates? Would love to see this out! Really cool IA. :) |
Closing this for now. Can always open it again! |
Labelling as abandoned, perhaps someone from the community can finish this one up |
@puskin94 please take a look at the feedback given here: https://github.com/duckduckgo/zeroclickinfo-goodies/pull/740/files and make sure everything has been addressed. I'm not sure what the current state of this IA is but once those are addressed and the above comments, we can give this one another look. |
A "quick and dirty" way to narrow down the trigger could be changing the trigger word to be |
@francisbrito that would work to reduce the query space somewhat; however if I searched for I think unless the query contains words that can be "lolcatted" i.e. ( @francisbrito Are you looking at finishing this off? Much appreciated if you are! |
@francisbrito @mintsoft a similar IA would be the "DuckSay" Spice where we've only allowed the trigger to come at the start of the IA: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/DuckSay.pm#L15 I think that would work in this case as well. We could also then check to make sure the words exist in the "lolcat dictionary" so that they can be translated. |
@mintsoft I didn't make clear the trigger in the post-fix example was @moollaza I agree. I'm thinking about using "lolcatsay" but it seems a little wordy. Maybe "lolsay" or "catsay" (all cats speak lolspeak after all ;))? |
@francisbrito Both approaches sound viable to me; we can have a review about which will work most effectively on the PR 👍 With regards to getting started etc, have you run through the quickstart (https://duck.co/duckduckhack/goodie_quickstart)? It's a pretty speedy introduction to the DDH architecture that should give you a good grounding. If you are having any problems you can always post to duckduckhack@listbox.com or open a PR and we'll help you out. |
@francisbrito @mintsoft If there is any kind of problem I can help finishing it :) |
What does your Instant Answer do?
Converts text into the LOLCAT language
What problem does your Instant Answer solve (Why is it better than organic links)?
It is a dynamic translator
What is the data source for your Instant Answer? (Provide a link if possible)
The Goodie PM file source code
https://github.com/JohnCarlosReed/zeroclickinfo-goodies/blob/master/lib/DDG/Goodie/LOLCAT.pm
What are some example queries that trigger this Instant Answer?
lolcat followed by any text
Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
meme lovers, cat people, geeks
Is this Instant Answer connected to a DuckDuckHack Instant Answer idea?
Yes: https://duck.co/ideas/idea/4595/lolcat-translator-goodie
Which existing Instant Answers will this one supercede/overlap with?
None
Are you having any problems? Do you need our help with anything?
No
Where did you hear about DuckDuckHack? (For first time contributors)
Searched for Perl open source projects
Checklist
Please place an 'X' where appropriate.