Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make sure Spice IA's check for a remainder (where applicable) #122

Closed
jagtalon opened this Issue Feb 6, 2013 · 12 comments

Comments

Projects
None yet
4 participants
Owner

jagtalon commented Feb 6, 2013

Example: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Canistreamit.pm

This plugin handles the remainder but doesn't check to make sure the remainder is defined or non empty. It should really make sure of this so that a search for "Streaming" does hit their endpoint with nothing.

@ghost ghost assigned jagtalon Feb 6, 2013

Owner

jagtalon commented Feb 6, 2013

Owner

moollaza commented Feb 6, 2013

Yup I already emailed them, they're currently fixing it. Thanks for the heads up though!

Member

majuscule commented Feb 6, 2013

Are there any problem cases for this or was it just the down time?

Owner

moollaza commented Feb 7, 2013

@nospampleasemam just down time. Keep it open for now until its working again (as a reminder)

Owner

jagtalon commented Feb 8, 2013

@nospampleasemam @moollaza it's up now.

@moollaza moollaza closed this Feb 8, 2013

Owner

jagtalon commented Feb 8, 2013

I think it checks if the remainder is defined or non-empty: https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Canistreamit.pm#L32

return unless $remainder =~ /^(?:can\s*i?|how\s*to|where\s*(?:to|can\s+i))?\s*(?:find\s+a)?\s*(.+)$/i;

@moollaza moollaza reopened this Feb 8, 2013

Owner

moollaza commented Feb 8, 2013

My mistake, this should still be open until we've gone through all the spice IA's

Owner

moollaza commented Jan 21, 2014

This is still an issue for a few Spice IA's:

Bitcoin for example does not make sure a remainder is defined - https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/lib/DDG/Spice/Bitcoin.pm#L24

Contributor

heytitle commented Jul 1, 2014

I can take a look at this issue if nobody takes it.

Owner

jagtalon commented Jul 21, 2014

@moollaza The Bitcoin Spice does the checking on the JS side (because, from what I understand, the list of currencies can change.) @heytitle If you'd like to take a look at Maven, go on right ahead. :)

@moollaza moollaza changed the title from Make sure Spice plugins check for a remainder (where applicable) to Make sure Spice IA's check for a remainder (where applicable) Jul 21, 2014

Owner

jagtalon commented Aug 18, 2014

Closed by #1000

@jagtalon jagtalon closed this Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment