Dilbert needs an icon_url #131

Closed
russellholt opened this Issue Feb 6, 2013 · 4 comments

Comments

Projects
None yet
4 participants
@russellholt
Contributor

russellholt commented Feb 6, 2013

in the metadata

@ghost ghost assigned majuscule Feb 6, 2013

@majuscule

This comment has been minimized.

Show comment Hide comment
@majuscule

majuscule Feb 6, 2013

Member

What's this for exactly? I assumed that this was only necessary when whatever core code we have to fetch an icon fails. It's pulling the right one on my dev node: https://dylan.duckduckgo.com/?q=dilbert

<img class="icon_spice_inline" src="//icons.duckduckgo.com/i/dilbert.com.ico">
Member

majuscule commented Feb 6, 2013

What's this for exactly? I assumed that this was only necessary when whatever core code we have to fetch an icon fails. It's pulling the right one on my dev node: https://dylan.duckduckgo.com/?q=dilbert

<img class="icon_spice_inline" src="//icons.duckduckgo.com/i/dilbert.com.ico">
@russellholt

This comment has been minimized.

Show comment Hide comment
@russellholt

russellholt Feb 7, 2013

Contributor

it's for the goodies page. it can't infer the source from any of metadata that is there

Contributor

russellholt commented Feb 7, 2013

it's for the goodies page. it can't infer the source from any of metadata that is there

@moollaza

This comment has been minimized.

Show comment Hide comment
@moollaza

moollaza Jan 21, 2014

Member

Is this still an issue? I don't see a Dilbert spice?

Member

moollaza commented Jan 21, 2014

Is this still an issue? I don't see a Dilbert spice?

@moollaza moollaza closed this Jan 21, 2014

@jagtalon

This comment has been minimized.

Show comment Hide comment
@jagtalon

jagtalon Jan 21, 2014

Member

You’re right—it’s not live in the first place. :)

Member

jagtalon commented Jan 21, 2014

You’re right—it’s not live in the first place. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment