New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trigger words for Japanese, Chinese and Korean #1703

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tagawa
Member

tagawa commented Mar 30, 2015

It's just the translation of "weather":
天気 => Japanese, Traditional Chinese
天气 => Simplified Chinese
날씨 => Korean

The IA result itself is not localized but the symbols and temperatures are easily understandable.

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Mar 30, 2015

Member

@tagawa thanks a lot for this PR, we really appreciate it. As you can imagine, internationalization is a very important component of DuckDuckGo, because we have users around the world. Right now almost all of our Instant Answers use English triggers and provide English results. We plan to eventually translate both our triggers and results, but for right now we're going to stick with English triggers. Our aim is to find a method that will work for all IAs rather than adding triggers sparsely to various IA's which will create an inconsistent experience. (e.g. why does forecast trigger in English, Korean and Chinese but nothing else does?)

So for now I'm going to close this, but please understand that this is something we're currently working towards.

Thanks again for taking the time to contribute!

Member

moollaza commented Mar 30, 2015

@tagawa thanks a lot for this PR, we really appreciate it. As you can imagine, internationalization is a very important component of DuckDuckGo, because we have users around the world. Right now almost all of our Instant Answers use English triggers and provide English results. We plan to eventually translate both our triggers and results, but for right now we're going to stick with English triggers. Our aim is to find a method that will work for all IAs rather than adding triggers sparsely to various IA's which will create an inconsistent experience. (e.g. why does forecast trigger in English, Korean and Chinese but nothing else does?)

So for now I'm going to close this, but please understand that this is something we're currently working towards.

Thanks again for taking the time to contribute!

@tagawa

This comment has been minimized.

Show comment
Hide comment
@tagawa

tagawa Mar 30, 2015

Member

Thanks for the explanation @moollaza - I fully understand. I've worked in internationalization previously and know it can be very complex so I appreciate the task ahead of you.

Another plan I have is to create Japanese-only IAs using Japanese web APIs and services, for example a local earthquake report IA. Would that be OK?

Member

tagawa commented Mar 30, 2015

Thanks for the explanation @moollaza - I fully understand. I've worked in internationalization previously and know it can be very complex so I appreciate the task ahead of you.

Another plan I have is to create Japanese-only IAs using Japanese web APIs and services, for example a local earthquake report IA. Would that be OK?

@tagawa tagawa referenced this pull request Jul 27, 2017

Closed

Timer: Added some non-english triggers #4385

7 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment