New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin Spice #320

Merged
merged 12 commits into from Nov 21, 2013

Conversation

Projects
None yet
5 participants
@jmg
Contributor

jmg commented Nov 11, 2013

bitcoin spice usd
bitcoin spice eur
bitcoin spice cny

I started the spice for this idea.

https://dukgo.com/ideas/idea/19/bitcoin-plugin

Please let me know what do you think. I'd love to improve it and see this feature live! Thanks

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

@jmg please post screenshots too for people to see. :)

Member

jagtalon commented Nov 12, 2013

@jmg please post screenshots too for people to see. :)

@ghost ghost assigned jagtalon Nov 12, 2013

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Nov 12, 2013

Contributor

@jagtalon Just added some images and fixed things you pointed out :)

Contributor

jmg commented Nov 12, 2013

@jagtalon Just added some images and fixed things you pointed out :)

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Nov 12, 2013

Member

Just wanted to mention that "$" should probably also indicated what kind of Dollar, e.g. "USD", "CAD", "AUD", etc

Member

moollaza commented Nov 12, 2013

Just wanted to mention that "$" should probably also indicated what kind of Dollar, e.g. "USD", "CAD", "AUD", etc

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Nov 12, 2013

Contributor

@moollaza yeah, you are right. That data is not on the API we are using unfortunately -> http://blockchain.info/ticker. It returns $ for any kind of dollar. So we should change that symbol on our side.

Contributor

jmg commented Nov 12, 2013

@moollaza yeah, you are right. That data is not on the API we are using unfortunately -> http://blockchain.info/ticker. It returns $ for any kind of dollar. So we should change that symbol on our side.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

@jmg You can put the currency in the header: "Bitcoin Exchange Prices (USD)". Thanks, @moollaza.

Member

jagtalon commented Nov 12, 2013

@jmg You can put the currency in the header: "Bitcoin Exchange Prices (USD)". Thanks, @moollaza.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

Or it could be "Bitcoin Exchange Prices in USD"

Member

jagtalon commented Nov 12, 2013

Or it could be "Bitcoin Exchange Prices in USD"

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Nov 12, 2013

Contributor

@jagtalon done :) "Bitcoin Exchange Prices (USD)" where USD could be any of the currencies we allow.

Contributor

jmg commented Nov 12, 2013

@jagtalon done :) "Bitcoin Exchange Prices (USD)" where USD could be any of the currencies we allow.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

@jmg We might not want to cache the results that we get. See https://dukgo.com/duckduckhack/spice_advanced_backend to see how to do just that.

Member

jagtalon commented Nov 12, 2013

@jmg We might not want to cache the results that we get. See https://dukgo.com/duckduckhack/spice_advanced_backend to see how to do just that.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

@jmg Some currencies have their symbols at the end instead of the beginning:

screen shot 2013-11-12 at 12 52 37 pm

Edit: Please double check the formatting of each currency and change accordingly. :)

Member

jagtalon commented Nov 12, 2013

@jmg Some currencies have their symbols at the end instead of the beginning:

screen shot 2013-11-12 at 12 52 37 pm

Edit: Please double check the formatting of each currency and change accordingly. :)

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

Oh, another thing: please add "Bitcoin:" at the beginning of your commit, e.g., "Bitcoin: Removed div tag". And if possible be very descriptive. Just a convention.

Member

jagtalon commented Nov 12, 2013

Oh, another thing: please add "Bitcoin:" at the beginning of your commit, e.g., "Bitcoin: Removed div tag". And if possible be very descriptive. Just a convention.

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Nov 12, 2013

Contributor

@jagtalon Sounds good. Just added no cache. Will check the currencies format next!

Contributor

jmg commented Nov 12, 2013

@jagtalon Sounds good. Just added no cache. Will check the currencies format next!

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 12, 2013

Member

@jmg Sweet! Looking forward to it. :)

Member

jagtalon commented Nov 12, 2013

@jmg Sweet! Looking forward to it. :)

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Nov 13, 2013

Contributor

@jagtalon the last commit jmg@6539b77 corresponds to the right format for currencies that uses the symbol at the end. According to wolframalpha only PLN and SEK have this type of format.

Contributor

jmg commented Nov 13, 2013

@jagtalon the last commit jmg@6539b77 corresponds to the right format for currencies that uses the symbol at the end. According to wolframalpha only PLN and SEK have this type of format.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 13, 2013

Member

@jmg Got to test it. Formatting looks good. Please add these to the tests.

Member

jagtalon commented Nov 13, 2013

@jmg Got to test it. Formatting looks good. Please add these to the tests.

spice to => 'http://blockchain.info/ticker';
spice wrap_jsonp_callback => 1;
spice proxy_cache_valid => "418 1d";

This comment has been minimized.

@jagtalon

jagtalon Nov 13, 2013

Member

We can probably add triggers start => "bitcoin exchange in"

@jagtalon

jagtalon Nov 13, 2013

Member

We can probably add triggers start => "bitcoin exchange in"

This comment has been minimized.

@jmg

jmg Nov 13, 2013

Contributor

Yeah, I've no problem. But would the triggers any => "bitcoin", "bit coin", "bitcoin exchange", "bit coin exchange" also work? Or you think it's better to just trigger it when the query starts explicitly with "bitcoin exchange in"?

@jmg

jmg Nov 13, 2013

Contributor

Yeah, I've no problem. But would the triggers any => "bitcoin", "bit coin", "bitcoin exchange", "bit coin exchange" also work? Or you think it's better to just trigger it when the query starts explicitly with "bitcoin exchange in"?

This comment has been minimized.

@jagtalon

jagtalon Nov 18, 2013

Member

Oh weird. Looks like when I added triggers start => "bitcoin exchange in", some trigger words in triggers any stopped working. It might be a bug. But for now, having both triggers start => "bitcoin exchange in" and triggers startend => "bitcoin", ... should work for our purposes here. :)

@jagtalon

jagtalon Nov 18, 2013

Member

Oh weird. Looks like when I added triggers start => "bitcoin exchange in", some trigger words in triggers any stopped working. It might be a bug. But for now, having both triggers start => "bitcoin exchange in" and triggers startend => "bitcoin", ... should work for our purposes here. :)

This comment has been minimized.

@jmg

jmg Nov 18, 2013

Contributor

Yeah, I tried and wasn't working well so didn't know if this was the bug or "triggers start" and "triggers any" couldn't be together. Will use triggers start => "bitcoin exchange in" and triggers startend => "bitcoin" then.

@jmg

jmg Nov 18, 2013

Contributor

Yeah, I tried and wasn't working well so didn't know if this was the bug or "triggers start" and "triggers any" couldn't be together. Will use triggers start => "bitcoin exchange in" and triggers startend => "bitcoin" then.

This comment has been minimized.

@jagtalon

jagtalon Nov 19, 2013

Member

Nice.

@jagtalon

This comment has been minimized.

@jmg

jmg Nov 19, 2013

Contributor

Maybe I could open a bug for the weird behavior of "trigger any" and "trigger start" working togheter

@jmg

jmg Nov 19, 2013

Contributor

Maybe I could open a bug for the weird behavior of "trigger any" and "trigger start" working togheter

This comment has been minimized.

@moollaza

moollaza Nov 20, 2013

Member

@jmg this is actually a known bug -- we're working on it :)

@moollaza

moollaza Nov 20, 2013

Member

@jmg this is actually a known bug -- we're working on it :)

Show outdated Hide outdated t/Bitcoin.t

jagtalon added a commit that referenced this pull request Nov 21, 2013

@jagtalon jagtalon merged commit e8a8f9c into duckduckgo:master Nov 21, 2013

1 check passed

default The Travis CI build passed
Details
@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 21, 2013

Member

Nice!

Member

jagtalon commented Nov 21, 2013

Nice!

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Nov 22, 2013

Contributor

Awesome! Thanks @jagtalon. Just out of curiosity. When do you usually deploy?

Contributor

jmg commented Nov 22, 2013

Awesome! Thanks @jagtalon. Just out of curiosity. When do you usually deploy?

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Nov 22, 2013

Member

@jmg I have a bunch of instant answers that I have to deploy soon, actually. I'll definitely contact / notify you when it gets released. I just has to go through a final, internal review, and it should be ready! Great job on your timely replies, and on your work with the instant answer over all.

Member

jagtalon commented Nov 22, 2013

@jmg I have a bunch of instant answers that I have to deploy soon, actually. I'll definitely contact / notify you when it gets released. I just has to go through a final, internal review, and it should be ready! Great job on your timely replies, and on your work with the instant answer over all.

@ZitZ

This comment has been minimized.

Show comment
Hide comment
@ZitZ

ZitZ Jan 25, 2014

Contributor

What is the current status of this? It is a very useful feature. I would also like to inquire about the possibility of extending this to include other crypto-currencies such as dogecoin and litecoin. This would either require several different instant answers that work essentially the same way, or we can just improve this instant answer to accept other crypto currencies. We would have to use a different API. There are advantages and disadvantages to each. Using one API keeps all the code in one spot, but it could be messy if there isn't one really good API that supports all possible trading pairs, both crypto-crypto and crypto-traditional.

IMHO, they should be the same API, cryptocoincharts.info looks to be a promising API to handle this.

Contributor

ZitZ commented Jan 25, 2014

What is the current status of this? It is a very useful feature. I would also like to inquire about the possibility of extending this to include other crypto-currencies such as dogecoin and litecoin. This would either require several different instant answers that work essentially the same way, or we can just improve this instant answer to accept other crypto currencies. We would have to use a different API. There are advantages and disadvantages to each. Using one API keeps all the code in one spot, but it could be messy if there isn't one really good API that supports all possible trading pairs, both crypto-crypto and crypto-traditional.

IMHO, they should be the same API, cryptocoincharts.info looks to be a promising API to handle this.

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Jan 25, 2014

Contributor

@ZitZ I was doing some experiments with their API (http://www.cryptocoincharts.info/v2/tools/api) recently and it looks amazing. They provide a lot of crypto-crypto and crypto-traditional exchange rate pairs.

I think we can use the same instant answer with different triggers for each crypto-currency (bitcoin, litecoin, dogecoin, etc) and it will be really easy to extend and add more.

Contributor

jmg commented Jan 25, 2014

@ZitZ I was doing some experiments with their API (http://www.cryptocoincharts.info/v2/tools/api) recently and it looks amazing. They provide a lot of crypto-crypto and crypto-traditional exchange rate pairs.

I think we can use the same instant answer with different triggers for each crypto-currency (bitcoin, litecoin, dogecoin, etc) and it will be really easy to extend and add more.

@ZitZ

This comment has been minimized.

Show comment
Hide comment
@ZitZ

ZitZ Jan 25, 2014

Contributor

@jmg That is my thought exactly. You should start a branch that uses cryptocoincharts as the API. I still would like to see the bitcoin instant answer live, while the new development occurs.

Perhaps I am getting ahead of myself, but perhaps we can periodically update the triggers from the API, so each new crypto doesn't require a coding change and a redeployment.

Contributor

ZitZ commented Jan 25, 2014

@jmg That is my thought exactly. You should start a branch that uses cryptocoincharts as the API. I still would like to see the bitcoin instant answer live, while the new development occurs.

Perhaps I am getting ahead of myself, but perhaps we can periodically update the triggers from the API, so each new crypto doesn't require a coding change and a redeployment.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Jan 28, 2014

Member

Sorry about this—just having problems on the backend with regards to the Bitcoin instant answer. I’ll get back to you guys on this!

Member

jagtalon commented Jan 28, 2014

Sorry about this—just having problems on the backend with regards to the Bitcoin instant answer. I’ll get back to you guys on this!

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Jan 28, 2014

Contributor

@jagtalon no problem, just tell me if I can help by fixing something.
@ZitZ I will start working on the branch soon. I really look forward to have support for many crypto currencies apart from bitcoin 👍

Contributor

jmg commented Jan 28, 2014

@jagtalon no problem, just tell me if I can help by fixing something.
@ZitZ I will start working on the branch soon. I really look forward to have support for many crypto currencies apart from bitcoin 👍

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Jan 28, 2014

Member

@jmg Excited about Dogecoin support. :D

Member

jagtalon commented Jan 28, 2014

@jmg Excited about Dogecoin support. :D

@zekiel

This comment has been minimized.

Show comment
Hide comment
@zekiel

zekiel Feb 12, 2014

Member

@jmg any reason you're not including the conversions function? http://blockchain.info/tobtc

Most people are probably going to want to be able to do:
"3 BTC to USD"
"100 EUR to BTC"
etc.

Would you consider adding that? It could then replace all the Wolfram|Alpha bitcoin instant answers: https://duckduckgo.com/?q=3+BTC+to+USD

Member

zekiel commented Feb 12, 2014

@jmg any reason you're not including the conversions function? http://blockchain.info/tobtc

Most people are probably going to want to be able to do:
"3 BTC to USD"
"100 EUR to BTC"
etc.

Would you consider adding that? It could then replace all the Wolfram|Alpha bitcoin instant answers: https://duckduckgo.com/?q=3+BTC+to+USD

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Feb 12, 2014

Contributor

@zekiel there is no particular reason. It won't be hard to implement and it's a very good idea. I'll work on that.

Contributor

jmg commented Feb 12, 2014

@zekiel there is no particular reason. It won't be hard to implement and it's a very good idea. I'll work on that.

@zekiel

This comment has been minimized.

Show comment
Hide comment
@zekiel

zekiel Feb 14, 2014

Member

@jmg awesome! I'll update this thread: https://duck.co/ideas/idea/589/show-bitcoin-http-bitcoin-org-value-and-its-c Was re-reading some of the comments there (and the ones above) and noticed you seemed to like the cryptocoincharts.info api and I've heard positives things about coinbase's as well so would love your thoughts on what attracted you to blockchain

Member

zekiel commented Feb 14, 2014

@jmg awesome! I'll update this thread: https://duck.co/ideas/idea/589/show-bitcoin-http-bitcoin-org-value-and-its-c Was re-reading some of the comments there (and the ones above) and noticed you seemed to like the cryptocoincharts.info api and I've heard positives things about coinbase's as well so would love your thoughts on what attracted you to blockchain

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Feb 17, 2014

Member

@jmg Aaaand it's live! 👌

Member

jagtalon commented Feb 17, 2014

@jmg Aaaand it's live! 👌

@jagtalon

This comment has been minimized.

Show comment
Hide comment
Member

jagtalon commented Feb 17, 2014

@jmg

This comment has been minimized.

Show comment
Hide comment
@jmg

jmg Feb 17, 2014

Contributor

@jagtalon that's awesome! Really glad to see it live 👍

Contributor

jmg commented Feb 17, 2014

@jagtalon that's awesome! Really glad to see it live 👍

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Feb 17, 2014

Member

@jmg Really sorry that it took so long. This was the problem if you're interested. :) duckduckgo/duckduckgo#61

Member

jagtalon commented Feb 17, 2014

@jmg Really sorry that it took so long. This was the problem if you're interested. :) duckduckgo/duckduckgo#61

@ZitZ

This comment has been minimized.

Show comment
Hide comment
@ZitZ

ZitZ Feb 22, 2014

Contributor

I'm so glad this is live, it is so useful for me. I'm sad that bing beat us though. :(

Contributor

ZitZ commented Feb 22, 2014

I'm so glad this is live, it is so useful for me. I'm sad that bing beat us though. :(

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Feb 24, 2014

Member

@ZitZ It's not complete, though. We still need to handle queries such as 10 usd to btc and vise versa. You can make that yourself if you want. :)

Member

jagtalon commented Feb 24, 2014

@ZitZ It's not complete, though. We still need to handle queries such as 10 usd to btc and vise versa. You can make that yourself if you want. :)

@jagtalon

This comment has been minimized.

Show comment
Hide comment
Member

jagtalon commented Apr 7, 2014

@zekiel

This comment has been minimized.

Show comment
Hide comment
@zekiel

zekiel Apr 7, 2014

Member

are high fives still a thing? If so,

Member

zekiel commented Apr 7, 2014

are high fives still a thing? If so,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment