First commit of improved zipcode plugin #62

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@almanackist

@moollaza Give this a try. Tweaked the regex to pick up codes with spaces, and restricted the "similar postcodes" to ones that exactly match the result.

L1P 1L5
150-0002
11217

@moollaza moollaza was assigned Jun 20, 2012
@moollaza
Member

@almanackist sorry for getting back to you so late, I went on a trip for a few days. Anyways looking at it now and it looks great! My only concern is the size and colour of the highlighted zipcode area. In the first result (on my screen at least) its very faint. I'm not sure if you can control that though...

One other thing, the click through link doesn't work. The js that gets run doesn't have access to the ENV variables so the api key doesn't get injected. Is there any publicly accessible url/data that we can forward the user to? Also I'd prefer not to hardcode the API key (or show it at all..) as I believe it would enable people to make queries using our key.

@almanackist

Let me tinker with the highlighting and look at the clickthrough... Thanks
for the feedback.
On Jun 26, 2012 6:45 PM, "Zaahir Moolla" <
reply@reply.github.com>
wrote:

@almanackist sorry for getting back to you so late, I went on a trip for a
few days. Anyways looking at it now and it looks great! My only concern is
the size and colour of the highlighted zipcode area. In the first result
(on my screen at least) its very faint. I'm not sure if you can control
that though...

One other thing, the click through link doesn't work. The js that gets run
doesn't get access the the ENV variables so the api key doesn't get
injected. Is there any publicly accessible url/data that we can forward the
user to? Also I'd prefer not to hardcode the API key (or show it at all..)
as I believe it would enable people to make queries using our key.


Reply to this email directly or view it on GitHub:

#62 (comment)

@almanackist

I fiddled with the padding and made the highlighted area slightly darker. It's hard to get the padding right for both very small and very large postcode areas, but right now it seems like a decent balance across the initial set of examples I sent, and some others I've looked at.

I don't know of another decent publicly accessible target we could forward users to (not in all cases, anyway). Do you always have a link out?

I also need to work on the similar postcodes bit some more. For some reason, the API doesn't want to return the right place in all cases, even when I'm specifying a country. I have an idea, though...

@moollaza
Member
moollaza commented Jul 9, 2012

@almanackist thanks a lot this looks great. Just wondering, can we make the map snippet any wider? Would love to fill up the blank space to the right of the map image -- it just feels so empty.

I believe we always do have a link out -- Just realized because its a mapquest map, we might as well link to a larger version (its something at least) so just link to http://www.mapquest.com/?q=<query>

@almanackist

Sure, what's the max width to fill? And I'll fix the outgoing link...that's
probably the best option, you're right.
On Jul 9, 2012 5:36 PM, "Zaahir Moolla" <
reply@reply.github.com>
wrote:

@almanackist thanks a lot this looks great. Just wondering, can we make
the map snippet any wider? Would love to fill up the blank space to the
right of the map image -- it just feels so empty.

I believe we always do have a link out -- Just realized because its a
mapquest map, we might as well link to a larger version (its something at
least) so just link to http://www.mapquest.com/?q=<query>


Reply to this email directly or view it on GitHub:

#62 (comment)

@moollaza
Member
moollaza commented Jul 9, 2012

@almanackist I'm not actually sure -- try 600px? Is the width set in the css? If so just filling the width of the container would be great so it still looks good when people have their DDG settings set to use the wide or super wide results.

@moollaza
Member

@almanackist when you get a chance, would you mind sending an email to moollaza@duckduckgo.com please? Or if you don't mind, can I have your email address? (We have some goodies for our contributors!)

@moollaza
Member

@almanackist thanks again for submitting this plugin. I've merged it with some minor visual changes.

@moollaza moollaza closed this Jul 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment