Social Media Sharing #11

Merged
merged 5 commits into from Jan 3, 2014

Conversation

Projects
None yet
3 participants
@jakevdp
Contributor

jakevdp commented May 6, 2013

This PR adds settings to enable sharing via twitter, google plus, and/or facebook. See the modified README file for instructions.

@duilio

This comment has been minimized.

Show comment
Hide comment
@duilio

duilio May 6, 2013

Owner

Hi Jake, thank you for the PR. :-)
Before doing the merge I was thinking about fixing the default values of the twitter/plus settings.
I've found this that might help:
http://jinja.pocoo.org/docs/templates/#default

Also.. can you add yourself to the author list? ;-)

Owner

duilio commented May 6, 2013

Hi Jake, thank you for the PR. :-)
Before doing the merge I was thinking about fixing the default values of the twitter/plus settings.
I've found this that might help:
http://jinja.pocoo.org/docs/templates/#default

Also.. can you add yourself to the author list? ;-)

@jakevdp

This comment has been minimized.

Show comment
Hide comment
@jakevdp

jakevdp May 6, 2013

Contributor

One thing that may be confusing is the need to use 'true' and 'false' strings, rather than ``TrueandFalse` boolean values for some of the parameters. Changing that will complicate the template -- what do you think?

Contributor

jakevdp commented May 6, 2013

One thing that may be confusing is the need to use 'true' and 'false' strings, rather than ``TrueandFalse` boolean values for some of the parameters. Changing that will complicate the template -- what do you think?

@hazelnusse

This comment has been minimized.

Show comment
Hide comment
@hazelnusse

hazelnusse Jul 24, 2013

I just started using Pelican and like this theme a lot. Any chance this PR is going to get merged? Also @jakevdp , it appears your Google+ button on Pythonic Perambulations does not work -- for some reason Google doesn't let you use your normal Google username in the plus link, instead it is a long number (e.g.: https://plus.google.com/118331842568896227320).

I just started using Pelican and like this theme a lot. Any chance this PR is going to get merged? Also @jakevdp , it appears your Google+ button on Pythonic Perambulations does not work -- for some reason Google doesn't let you use your normal Google username in the plus link, instead it is a long number (e.g.: https://plus.google.com/118331842568896227320).

@jakevdp

This comment has been minimized.

Show comment
Hide comment
@jakevdp

jakevdp Jul 24, 2013

Contributor

Yes, I know, and there are also some issues with the new twitter API 😒
I haven't had the time to look at fixing those...

Contributor

jakevdp commented Jul 24, 2013

Yes, I know, and there are also some issues with the new twitter API 😒
I haven't had the time to look at fixing those...

@duilio

This comment has been minimized.

Show comment
Hide comment
@duilio

duilio Sep 1, 2013

Owner

Still interested in fixing this PR? :-)

Owner

duilio commented Sep 1, 2013

Still interested in fixing this PR? :-)

@jakevdp

This comment has been minimized.

Show comment
Hide comment
@jakevdp

jakevdp Sep 3, 2013

Contributor

Still interested, yes, but I lack the time right now...

Contributor

jakevdp commented Sep 3, 2013

Still interested, yes, but I lack the time right now...

@nt3rp nt3rp referenced this pull request Oct 29, 2013

Merged

Social Media Sharing #28

@duilio duilio merged commit 50925a0 into duilio:master Jan 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment