Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

article footer extended #62

Merged
merged 1 commit into from Jan 3, 2015
Merged

article footer extended #62

merged 1 commit into from Jan 3, 2015

Conversation

mstreuhofer
Copy link
Contributor

added the article's category to the info shown in the footer
separate the tags by comma in the article's info shown in the footer
link author's name in the article's footer to author's list of articles

added the article's category to the info shown in the footer
separate the tags by comma in the article's info shown in the footer
link author's name in the article's footer to author's list of articles
duilio added a commit that referenced this pull request Jan 3, 2015
@duilio duilio merged commit f751ca3 into duilio:master Jan 3, 2015
@mstreuhofer mstreuhofer deleted the article-footer branch January 3, 2015 12:16
@@ -1,12 +1,17 @@
<p class="meta">
<span class="byline author vcard">
Posted by <span class="fn">{{ article.author }}</span>
Posted by <span class="fn">
<a href="{{ SITEURL }}/{{ article.author.url }}">{{ article.author }}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes the existence of article.author.url, which is not a guarantee. Can having a link here be opt-in instead of always on?

@mstreuhofer
Copy link
Contributor Author

how is this not guaranteed? which config var would have to be set for this to be empty?

@dhermes
Copy link
Contributor

dhermes commented Jan 3, 2015

In my posts I use:

author: Danny Hermes (dhermes@bossylobster.com)

in the metadata and I'm sure others use similar. (I have no reason for this other than that is what the conversion from Blogger spit out.)

ISTM to get article.url I'd need nested key-value pairs.

@mstreuhofer
Copy link
Contributor Author

article.author.url will be filled by pelican with a proper address to an index page listing all articles of $author. this is why the template author.html was added too (see PR #65).

@dhermes
Copy link
Contributor

dhermes commented Jan 3, 2015

Gotcher. SGTM.

@mstreuhofer
Copy link
Contributor Author

#69 should be in your interest. the author's name would only be linked if the pelican config states that an all-authors-overview should be created (AUTHORS_SAVE_AS) - being understood as "more than one author exists". Otherwise it is assumed only one author exists and the name won't get linked in the article's footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants