Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Periodically clean old requests instead of after every request that is performed. #216

Closed
dukeofharen opened this issue Feb 5, 2022 · 0 comments
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@dukeofharen
Copy link
Owner

dukeofharen commented Feb 5, 2022

Feature Request

Describe the Feature Request

There is a mechanism in place to delete old requests, to save disk space and let the application perform better. The deletion of requests is now, however, done after every performed request.

Describe Preferred Solution

It would be better if a the application has a scheduled job that would execute the deletion of old requests. This way, the request execution is not responsible anymore for deleting the old requests. A larger number of requests may still be available in HttPlaceholder that still need to be cleaned, until the scheduled job has been executed. A con for HttPlaceholder instances that are hosted in the cloud and use a serverless database, is that when the scheduled job runs, extra costs might occur. To combat this, the old option of deleting old requests after the execution of a request, should still be possible. This should be configurable by using a configuration option. So the option is either to clean old requests using the scheduled job OR after every executed request.

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

@dukeofharen dukeofharen added the enhancement Enhancement of the code, not introducing new features. label Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

No branches or pull requests

1 participant