Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make it possible to show the configuration in the UI #261

Closed
dukeofharen opened this issue Aug 14, 2022 · 1 comment · Fixed by #270
Closed

feat: Make it possible to show the configuration in the UI #261

dukeofharen opened this issue Aug 14, 2022 · 1 comment · Fixed by #270
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@dukeofharen
Copy link
Owner

Feature Request

Describe the Feature Request

Right now, the configuration is only printed when starting the application in verbose modus. It would be nice to show the configuration in the UI on the "Settings" page.

Describe Preferred Solution

A new API endpoint has to be added to retrieve the configuration. Some values should be considered secure (like username, password, PFX password etc.) so these should be shown as "*" on the page. Also, make it clear the settings are read only and can NOT be changed in the UI.

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

@dukeofharen dukeofharen added the enhancement Enhancement of the code, not introducing new features. label Aug 14, 2022
@dukeofharen
Copy link
Owner Author

image

@dukeofharen dukeofharen linked a pull request Sep 5, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant