Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/several UI changes #169

Merged
merged 17 commits into from
Oct 23, 2021
Merged

Fix/several UI changes #169

merged 17 commits into from
Oct 23, 2021

Conversation

dukeofharen
Copy link
Owner

@dukeofharen dukeofharen commented Oct 17, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #168

What is the new behavior?

The form helpers as shown on the stub form can be presented in a large list instead of a collapsable accordion. You should be able to filter the stub helpers.

image
New stub form helper list with filter

In dark mode, the "response body" form helper form is still white.

Fix sidemenu so you can click on the whole menu item instead of only on the text.

In dark mode, you can barely make out the difference between an enabled and disabled stub.

image
I added the "(disabled)" text again, just like in the "old" UI.

After saving a stub, a redirect to the stub form with the added stub ID should be done.

Make a difference between updating a new and existing stub. Right now, when you update the ID of an existing stub, a new stub will be added and the stub with the old ID still exists. Add a separate button for updating a stub so the old stub will be deleted.

image
When you are in "new stub" mode, only the "Save" button will be shown which always adds the stub (of course). When you are in "update stub" mode, the "Save" button will call the "update" endpoint, which means when you update the stub ID, the stub with the old ID will not remain. If you want to do some kind of batch adding through the stub form, you can press the "Save as new stub" option, so that when you update the stub ID, the stub with the old ID will remain.

Checkboxes should also be dark in dark mode.

image

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dukeofharen dukeofharen linked an issue Oct 17, 2021 that may be closed by this pull request
@dukeofharen dukeofharen added the enhancement Enhancement of the code, not introducing new features. label Oct 17, 2021
@dukeofharen dukeofharen merged commit 72b9499 into master Oct 23, 2021
@dukeofharen dukeofharen deleted the fix/several-ui-changes branch October 23, 2021 07:42
@dukeofharen dukeofharen restored the fix/several-ui-changes branch July 17, 2022 06:53
@dukeofharen dukeofharen deleted the fix/several-ui-changes branch July 17, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: several UI changes in the new UI
1 participant