-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/several UI changes #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukeofharen
added
the
enhancement
Enhancement of the code, not introducing new features.
label
Oct 17, 2021
…buttons when input only has one stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #168
What is the new behavior?
The form helpers as shown on the stub form can be presented in a large list instead of a collapsable accordion. You should be able to filter the stub helpers.
New stub form helper list with filter
In dark mode, the "response body" form helper form is still white.
Fix sidemenu so you can click on the whole menu item instead of only on the text.
In dark mode, you can barely make out the difference between an enabled and disabled stub.
I added the "(disabled)" text again, just like in the "old" UI.
After saving a stub, a redirect to the stub form with the added stub ID should be done.
Make a difference between updating a new and existing stub. Right now, when you update the ID of an existing stub, a new stub will be added and the stub with the old ID still exists. Add a separate button for updating a stub so the old stub will be deleted.
When you are in "new stub" mode, only the "Save" button will be shown which always adds the stub (of course). When you are in "update stub" mode, the "Save" button will call the "update" endpoint, which means when you update the stub ID, the stub with the old ID will not remain. If you want to do some kind of batch adding through the stub form, you can press the "Save as new stub" option, so that when you update the stub ID, the stub with the old ID will remain.
Checkboxes should also be dark in dark mode.
Does this introduce a breaking change?
Other information