Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/persist filter states #176

Merged
merged 5 commits into from
Oct 23, 2021
Merged

Conversation

dukeofharen
Copy link
Owner

@dukeofharen dukeofharen commented Oct 23, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, when you fill in a filter on the stubs or requests page in the UI, the search results are not persisted when you navigate to another page.

Issue Number: N/A

What is the new behavior?

  • When filling in the filter on the stubs or requests pages, the filter will be persisted and when you navigate back to any of the pages, the filter will still be filled in.
  • This functionality can be turned on or off.
    image
  • I also made it possible to search on the requests screen using the request correlation ID (small oversight from the past).

Does this introduce a breaking change?

  • Yes
  • No

Yes, but only a very small one. Because the settings are saved a bit differently, you need to enable the dark theme once again.

Other information

@dukeofharen dukeofharen added the enhancement Enhancement of the code, not introducing new features. label Oct 23, 2021
@dukeofharen dukeofharen merged commit 1f31b64 into master Oct 23, 2021
@dukeofharen dukeofharen deleted the feature/persist-filter-states branch October 23, 2021 20:46
@dukeofharen dukeofharen restored the feature/persist-filter-states branch July 17, 2022 06:53
@dukeofharen dukeofharen deleted the feature/persist-filter-states branch July 17, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant