Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in deserialization of HAR #271

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

dukeofharen
Copy link
Owner

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

You can create stubs based on an HTTP archive (or HAR for short). When downloading a HAR from Firefox, the "headersSize" element of "request" was null, which resulted in an exception.

What is the new behavior?

The field "headersSize" is now optional.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dukeofharen dukeofharen added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Sep 12, 2022
@dukeofharen dukeofharen merged commit 860dbe4 into master Sep 13, 2022
@dukeofharen dukeofharen deleted the bug/har-headers-size branch September 14, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant