Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off fontsize calculation #21

Closed

Conversation

cjblomqvist
Copy link

See #20 which is part of this PR as well.

Adds support for turning of automatic font-size calculations (and turning of setting font-size at all). It's currently not easily possible to override the font-size and set it to something fixed - this is now possible by turning off the automatic font-size calculations.

@detaybey
Copy link

waiting for this fix <3

@detaybey
Copy link

stuck with README.md conflict.... :/

@dumptyd
Copy link
Owner

dumptyd commented Mar 18, 2020

There are a few reasons I didn't go with this PR.

  • Unrelated files are being changed.
  • The implementation doesn't completely remove the elements that are involved in font size recalc (like the resize event listener)
  • The new prop isn't documented and the demo page isn't updated.

Now, I don't expect anyone to know these things as they start working on this repo because I haven't created a contributing guide yet. I will create one soon when I get time though.

Again, thanks a lot for showing interest in contributing to the repo, I really appreciate it. But for now, I'm closing this PR as I've created a new one with different implementation - #30. You can check out the diff there to see how it's being implemented and what things are updated.


@detaybey You can track this in #30 as well. 🙂

@dumptyd dumptyd closed this Mar 18, 2020
@dumptyd
Copy link
Owner

dumptyd commented Mar 22, 2020

This has been implemented in 1.3.0.

@cjblomqvist
Copy link
Author

Fair enough - thanks for your effort @dumptyd !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants