-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0: Improve DX of Gateways #811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: StyleCI Bot <bot@styleci.io>
…imple-commerce into simplify-gateway-dx
Co-authored-by: StyleCI Bot <bot@styleci.io>
…imple-commerce into simplify-gateway-dx
Released as part of v5.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the developer experience around building custom payment gateways.
The signatures for gateway methods have changed. Instead of dealing with custom objects, you're now dealing with simple arrays.
For developers building gateways for the first time, the
Gateway
contract now includes some documentation about each of the methods in docblocks.Upgrade Guide
As part of improving the developer experience, there's been some changes the API for implementing custom gateways.
If you're using a custom gateway, you will need to make some manual changes:
prepare
$request
and$order
parameters, instead of aPrepare
object.Response
, instead it simply returns an array.purchase
checkout
$request
and$order
parameters, instead of aPrepare
object.Response
, instead it simply returns an array.purchaseRules
checkoutRules
purchaseMessages
checkoutMessages
getCharge
refundCharge
refund
array
. The contents of which will be saved to the order's gateway data for future reference.paymentDisplay
fieldtypeDisplay
To Do
refund
method for future reference