Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map rendered somwehat strangely #13

Closed
anaderi opened this issue Oct 16, 2016 · 8 comments
Closed

map rendered somwehat strangely #13

anaderi opened this issue Oct 16, 2016 · 8 comments

Comments

@anaderi
Copy link

anaderi commented Oct 16, 2016

(see on the right)
image

Atom: 1.13.0-dev-11f8d9e
Platform: Mac OS X (El capitan)
v0.2.4

@lyndametref
Copy link

lyndametref commented Nov 18, 2016

I have the same problem. Was there an atom update that broke this package?

Atom 1.12.4
Windows 7
markdown-mindmap v0.2.4

@luddek
Copy link

luddek commented Nov 18, 2016

This is because of a deprecation of how markmap is getting the width and height in chrome: https://www.chromestatus.com/features/5724912467574784
I've added a pull request to markmap: dundalek/markmap#7
If you want to change it yourself it is just two lines of code.

@lyndametref
Copy link

@luddek : Awesome, it fixed it perfectly for me!

@chenzeyu
Copy link

@luddek How can I apply your changes manually in Atom?

@luddek
Copy link

luddek commented Nov 21, 2016

@chenzeyu
Change line 129 and 130 in
~/.atom/packages/markdown-mindmap/node_modules/markmap/view.mindmap.js
to

    state.height = svg.node().getBoundingClientRect().height;
    state.width = svg.node().getBoundingClientRect().width;

@RickTorresJr
Copy link

@luddek
Required a restart of Atom but worked perfectly. Big thanks.

@ChrisChinchilla
Copy link

@dundalek How can we get this fixed? Is there a way to override in your code?

@dundalek
Copy link
Owner

This is now fixed and published, update to the latest version v0.2.5 inside Atom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants