Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.dirname is deprecated. #43

Closed
ljsinclair opened this issue Apr 20, 2019 · 4 comments
Closed

Object.dirname is deprecated. #43

ljsinclair opened this issue Apr 20, 2019 · 4 comments

Comments

@ljsinclair
Copy link

@ljsinclair ljsinclair commented Apr 20, 2019

Argument to path.dirname must be a string

Object.dirname (C:\Users\gothe\AppData\Local\atom\app-1.28.0\resources\app.asar\src\electron-shims.js:9:10)
transformLinks (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:42:16)
MarkdownMindmapView.parseMarkdown (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:398:32)
MarkdownMindmapView.renderMarkdownText (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:403:19)
<unknown> (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:242:26)
<unknown> (null:null:null)
@hueri

This comment has been minimized.

Copy link

@hueri hueri commented Aug 1, 2019

Also seeing this - bummer, as it worked in a previous version!

hueri added a commit to hueri/atom-markdown-mindmap that referenced this issue Aug 5, 2019
Seems to be reported here : dundalek#43

Changed line 50 to convert argument to string.
hueri added a commit to hueri/atom-markdown-mindmap that referenced this issue Aug 11, 2019
Problem in latest versions reports "Argument to path.dirname must be a string"

Modifed argument to refer to filepath as Script(filepath)
@dundalek

This comment has been minimized.

Copy link
Owner

@dundalek dundalek commented Aug 11, 2019

I was able to give it a look today. I cannot reproduce the issue, so it is probably a bug in the parser which is probably caused by some particular markdown. It would be helpful if you could share the markdown content with which you encounter this issue (make sure to redact out any private and sensitive content before sharing).

@hueri

This comment has been minimized.

Copy link

@hueri hueri commented Aug 11, 2019

@dundalek dundalek closed this in 26cc337 Aug 11, 2019
@dundalek

This comment has been minimized.

Copy link
Owner

@dundalek dundalek commented Aug 11, 2019

Should be fixed in the latest version 0.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.