fix: content truncated because response end is called too early #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dunglas why do we have the pipeStream on the options argument of the serveFragment ? |
Contributor
Author
|
ping @dunglas |
1 similar comment
Contributor
Author
|
ping @dunglas |
dunglas
approved these changes
Jan 8, 2021
Owner
|
Thanks @jamyouss, sorry for the delay! |
Contributor
Author
No problem. Happy new year :) |
Contributor
Author
|
don't forget to release the fix when can please :) |
|
Hello @dunglas , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case the res.end is called too early. We should let the pipe end the writer when the reader ends.
Tested with large ESI.
The transformation is working but the last part is not sent.