Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flacky test #21

Closed
dunglas opened this issue Oct 14, 2019 · 0 comments · Fixed by #23
Closed

Fix flacky test #21

dunglas opened this issue Oct 14, 2019 · 0 comments · Fixed by #23
Labels

Comments

@dunglas
Copy link
Owner

@dunglas dunglas commented Oct 14, 2019

Tests fail randomly because - by design - pushes can be received in any order: https://github.com/dunglas/vulcain/runs/258924155

Doing a diff here doesn't work. What we must check is that all logs are created, regardless of the order.

dunglas added a commit that referenced this issue Oct 15, 2019
@dunglas dunglas closed this in #23 Oct 16, 2019
dunglas added a commit that referenced this issue Oct 16, 2019
Fix flacky test. Close #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.