Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Tweaked the javadoc comments
- Loading branch information
Showing
1 changed file
with
15 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d54a807
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a) Granularity level should ideally be enums
b) Instead of serialization key=string, value=string, I would suggest key='json' i.e. int64 and value='json' i.e. [ {'time_stamp':'int64', 'log':'string' } ]
c) Should give example config folder with a cluster.xml,stores.xml and server.properties for quick start