Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex support on find_elements closes #21 #22

Merged
merged 13 commits into from Oct 14, 2018
Merged

regex support on find_elements closes #21 #22

merged 13 commits into from Oct 14, 2018

Conversation

dunossauro
Copy link
Owner

Closes #21

@coveralls
Copy link

coveralls commented Oct 8, 2018

Pull Request Test Coverage Report for Build 43

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 41: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@dunossauro
Copy link
Owner Author

Anyone can review this code?

@williangl, @rg3915 ... ???

@rg3915
Copy link
Contributor

rg3915 commented Oct 9, 2018

Anyone can review this code?

@williangl, @rg3915 ... ???
👍

@dunossauro
Copy link
Owner Author

@meiralins posso mergear? xD

@heliomeiralins
Copy link

@dunossauro I took another look and it's missing tests of the default behavior of the _num_or_match.
Perhaps you could implement the Number behavior in the default behavior. In this way, it would be tested and you add support for other types.

Also, consider renaming _num_or_match. Perharps matcher would do.

@dunossauro dunossauro merged commit ec434cd into master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants