Five calls to notify-send produce six notifications on screen

[dubhater]

Hi!

Sometimes there are exactly five new messages in my inbox and Thunderbird + GNotifier addon make dunst display something like this:

And when those five notifications disappear, then the fifth message appears.

The thing is, if it's okay to display five notifications at the same time, dunst should just display the five messages it received. If five notifications are too many, then it should only display four, the fourth being "(2 more)".

The above picture was generated with the command for i in {1..5}; do notify-send asdf "the quick brown fox jumps over the $i lazy dogs"; done

Installation info

• Version: 1.2.0, but also tried latest from master
• Install type: "dunst" package from Arch Linux's "community" repository, or "dunst-git" package from AUR
• Distro and version: 64 bit Arch Linux

[bebehei]

@tsipinakis The relevant codebits are here:

dunst/src/x11/x.c

Lines 1023 to 1031 in 5009d44

	/* calculate maximum notification count and push information to queue */
	if (xctx.geometry.h == 0) {
	queues_displayed_limit(0);
	} else if (xctx.geometry.h == 1) {
	queues_displayed_limit(1);
	} else if (settings.indicate_hidden) {
	queues_displayed_limit(xctx.geometry.h - 1);
	} else {
	queues_displayed_limit(xctx.geometry.h);

dunst/src/x11/x.c

Lines 538 to 539 in 5009d44

	int qlen = queues_length_waiting();
	bool xmore_is_needed = qlen > 0 && settings.indicate_hidden;

Related: #431 #301

[bebehei]

@tsipinakis Also I'd like to add: The xmore layout is always generated from the latest displayed message. I'd say this is rather confusing. It would be better to derive it from the first message in the waiting queue.