max_icon_size is broken when dynamic width is used

[catzybluphish]

Installation info

• Version: 1.4.0 (2019-03-30)
• Install type: package
• Distro and version: Arch

The max_icon_size setting is broken. Any value will make the icon show at its maximum size. Setting it to 0 will still enable icons. Am I missing something?

[tsipinakis]

It works on my end, can you post your dunstrc and a test case to try and reproduce this?

[catzybluphish]

It works on my end, can you post your dunstrc and a test case to try and reproduce this?

This is the dunstrc I use.
Ever since I updated dunst from the Arch's repos, the icon setting is broken. I've even switched out for the new /usr/share/dunst/dunstrc but that didn't help. All I did was:

1. update dunst
2. change to new dunstrc

Same issue here on arch.

[tsipinakis]

Reproduced, the bug comes from c99f715 I forgot to check whether the width was 0 so it capped the max_icon_size to 0 automatically if dynamic width is used, oops.

@catzybluphish @Fwanky Can you build tsipinakis@dda26bf to confirm if this fixes the issue?

[catzybluphish]

Reproduced, the bug comes from c99f715 I forgot to check whether the width was 0 so it capped the max_icon_size to 0 automatically if dynamic width is used, oops.

@catzybluphish @Fwanky Can you build tsipinakis@dda26bf to confirm if this fixes the issue?

Thanks! It's fixed. While I'm still here, I have a feature suggestion. Since I'm using geometry = "0x0-20+41" (dynamic width as you call it), I'd like there to be some space between the icon and text. As you can see in this image:

The space in between is only as much as my horizontal_padding, and increasing it will add more space to the left of the icon. Is there a way to create a gap between them without setting a fixed width or using padding that also adds space to the right and left?

[tsipinakis]

While I'm still here, I have a feature suggestion [...]

This has been requested before, see #543. The code that handles the layout creation needs some cleanup and proper testing before anything can be changed there.

I'll get around to it someday, but as is usual in open source if you want to help PRs are always welcome.