1.7.0: Wayland: dunst segfaults on hikari compositor

[Narrat]

Installation info

As I ran 1.6.1 until now, I just noticed an issue with my wayland compositor in use (hikari) and the latest dunst release.

Not sure how to interpret the error message though, but here you go:

$ dunst -conf - </dev/null
WARNING: First roundtrip
WARNING: Binding to output 19
WARNING: Second roundtrip
WARNING: Third roundtrip
WARNING: compositor doesn't support zwlr_foreign_toplevel_v1. Fullscreen detection won't work
zsh: segmentation fault (core dumped)  dunst -conf - < /dev/null

Dunno why there should be an output 19 oO There is just wayland-0 and :0 available.

• Install type: package and manually
• Distro and version: Arch Linux 1.7.0-2 and built from source

I did a git bisect and it points to commit 0671c09

0671c09ede40357575e0f21f1a7907147dab8fbe is the first bad commit
commit 0671c09ede40357575e0f21f1a7907147dab8fbe
Author: fwsmit <fw.smit01@gmail.com>
Date:   Wed Oct 6 17:43:34 2021 +0200

    wayland: rewrite foreign toplevel support
    
    This is mostly taken from examples/foreign-toplevel.c of wlroots.

 src/wayland/foreign_toplevel.c | 177 +++++++++++++++++++++++++++++++++++++++++
 src/wayland/foreign_toplevel.h |  33 ++++++++
 src/wayland/wl.c               | 174 ++++++++++------------------------------
 src/wayland/wl_output.c        |   3 +
 src/wayland/wl_output.h        |  20 +++++
 5 files changed, 274 insertions(+), 133 deletions(-)
 create mode 100644 src/wayland/foreign_toplevel.c
 create mode 100644 src/wayland/foreign_toplevel.h
 create mode 100644 src/wayland/wl_output.c
 create mode 100644 src/wayland/wl_output.h

Is this an issue with dunst or is hikari in the wrong here?

[fwsmit]

Thanks for the bug report. Dunst should still work, even when it doesn't support the zwlr_foreign_toplevel_v1 protocol. It's fixed now in 1d7bfbe.

[Narrat]

Works like a charm.
Thanks for the quick fix :)