Allow negative offsets (fixes issue #1026)#1027
Merged
fwsmit merged 2 commits intodunst-project:masterfrom Feb 17, 2022
Merged
Conversation
Member
|
I've tested it on wayland and it works as well. Might be good to say in the docs that a negative offset will lead to the notification being off screen. |
Member
|
@kurogetsusai, could you take a look at my above comment and update the documentation accordingly? It looks good otherwise |
Contributor
Author
|
Thanks for testing it on Wayland! I'll update the documentation as soon as I get to my laptop. Sorry for the delay. |
Contributor
Author
|
I updated the docs. Let me know if there's anything else you'd like me to change. |
Member
|
Thanks for the update, I'll go ahead and merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you want that feature in dunst or not, but this PR fixes regression introduced in 1a456a5 which made it impossible to use negative offsets (issue #1026). I personally think it's useful. Tested on X11 only. I don't have Wayland around, sorry.
fixes #1026