Skip to content

Add history-rm command#1128

Merged
fwsmit merged 5 commits into
dunst-project:masterfrom
fapfaff:master
Dec 13, 2022
Merged

Add history-rm command#1128
fwsmit merged 5 commits into
dunst-project:masterfrom
fapfaff:master

Conversation

@fapfaff

@fapfaff fapfaff commented Nov 20, 2022

Copy link
Copy Markdown
Contributor

Implements #308

Comment thread dunstctl Outdated
Comment thread src/dbus.c Outdated
@fwsmit

fwsmit commented Nov 23, 2022

Copy link
Copy Markdown
Member

Looks good. There's only a warning from the compiler when compiling the test. Could you fix that?

@fapfaff

fapfaff commented Nov 23, 2022

Copy link
Copy Markdown
Contributor Author

Looks good. There's only a warning from the compiler when compiling the test. Could you fix that?

Should be fixed now

@fwsmit

fwsmit commented Nov 27, 2022

Copy link
Copy Markdown
Member

You have some memory leaks, probably in the tests. You can check this locally with make test-valgrind

@fapfaff

fapfaff commented Nov 27, 2022

Copy link
Copy Markdown
Contributor Author

It's fixed

@codecov-commenter

codecov-commenter commented Nov 27, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.37%. Comparing base (41d1a63) to head (e52022c).
⚠️ Report is 540 commits behind head on master.

Files with missing lines Patch % Lines
src/dbus.c 0.00% 7 Missing ⚠️
src/queues.c 85.71% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   65.26%   65.37%   +0.11%     
==========================================
  Files          46       46              
  Lines        7358     7420      +62     
==========================================
+ Hits         4802     4851      +49     
- Misses       2556     2569      +13     
Flag Coverage Δ
unittests 65.37% <78.57%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fwsmit fwsmit merged commit 41a3c6e into dunst-project:master Dec 13, 2022
@fwsmit

fwsmit commented Dec 13, 2022

Copy link
Copy Markdown
Member

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants