Skip to content

Add history-clear command#1131

Merged
fwsmit merged 3 commits intodunst-project:masterfrom
fapfaff:feature/history-clear
Dec 13, 2022
Merged

Add history-clear command#1131
fwsmit merged 3 commits intodunst-project:masterfrom
fapfaff:feature/history-clear

Conversation

@fapfaff
Copy link
Contributor

@fapfaff fapfaff commented Nov 23, 2022

Added command to remove all notifications from history.

@fwsmit
Copy link
Member

fwsmit commented Nov 23, 2022

Just curious, what do you use this for?

@fapfaff
Copy link
Contributor Author

fapfaff commented Nov 23, 2022

For an eww widget displaying my notification history

@fapfaff
Copy link
Contributor Author

fapfaff commented Nov 25, 2022

Do you have an idea why it doesn't build?
Shouldn't g_queue_clear_full() be included by glib.h?

Sorry for asking you my noob questions, but it's working locally without any problems and I couldn't find anything that helps me.

@fwsmit
Copy link
Member

fwsmit commented Nov 27, 2022

I'm guessing the version of glib for these distro's is too old. You need at least version 2.6 to get this function. I've ran the archlinux build again and it works. This seems to confirm my suspicion. vTake a look at https://docs.gtk.org/glib/struct.Queue.html for the version requirements of different functions.

You can work around this by using other queue functions in glib.

@fapfaff
Copy link
Contributor Author

fapfaff commented Nov 27, 2022

Thanks, I have replaced it. Should work now.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Merging #1131 (a590d4e) into master (bc04012) will increase coverage by 0.01%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   65.26%   65.27%   +0.01%     
==========================================
  Files          46       46              
  Lines        7358     7381      +23     
==========================================
+ Hits         4802     4818      +16     
- Misses       2556     2563       +7     
Flag Coverage Δ
unittests 65.27% <69.56%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dbus.c 52.10% <0.00%> (-0.79%) ⬇️
src/queues.c 92.00% <83.33%> (-0.20%) ⬇️
test/queues.c 98.88% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fapfaff fapfaff requested a review from fwsmit November 28, 2022 18:13
@fwsmit
Copy link
Member

fwsmit commented Dec 13, 2022

LGTM, thanks!

@fwsmit fwsmit merged commit dbe8367 into dunst-project:master Dec 13, 2022
liskin added a commit to liskin/dunst that referenced this pull request Nov 9, 2023
Fixes: dbe8367 ("Add history-clear command (dunst-project#1131)")
Fixes: 82fb1d9 ("remove d from pause level commands")
fwsmit pushed a commit that referenced this pull request Nov 10, 2023
Fixes: dbe8367 ("Add history-clear command (#1131)")
Fixes: 82fb1d9 ("remove d from pause level commands")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants