Skip to content

Run(): clear previous timer id if needed#1257

Merged
fwsmit merged 1 commit into
dunst-project:masterfrom
tobast:tbastian/fix_1196
Jan 30, 2024
Merged

Run(): clear previous timer id if needed#1257
fwsmit merged 1 commit into
dunst-project:masterfrom
tobast:tbastian/fix_1196

Conversation

@tobast

@tobast tobast commented Jan 14, 2024

Copy link
Copy Markdown
Contributor

Fixes #1196

All tests passing:

$ make test
[...]
Total: 189 tests (85447 ticks, 0.085 sec), 2430 assertions
Pass: 189, fail: 0, skip: 0.

@codecov-commenter

codecov-commenter commented Jan 14, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.10%. Comparing base (d314806) to head (e2329b4).
Report is 183 commits behind head on master.

Files Patch % Lines
src/dunst.c 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   66.17%   66.10%   -0.07%     
==========================================
  Files          46       46              
  Lines        7696     7701       +5     
==========================================
- Hits         5093     5091       -2     
- Misses       2603     2610       +7     
Flag Coverage Δ
unittests 66.10% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwsmit

fwsmit commented Jan 30, 2024

Copy link
Copy Markdown
Member

Thanks for the quick fix and taking responsibility for your code :). The fix looks good, so I'll go ahead and merge

@fwsmit fwsmit merged commit 705fcca into dunst-project:master Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glib errors (CRITICAL: Source ID 16 was not found when attempting to remove it)

3 participants