Wayland: suport GTK/CSS cursor names#1276
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
- Coverage 64.48% 64.46% -0.02%
==========================================
Files 48 48
Lines 7918 7920 +2
==========================================
Hits 5106 5106
- Misses 2812 2814 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adwaita, the default icon theme for many distributions, decided to stop providing legacy Xcursor icons in favor of the GTK/CSS names[1]. This requires us to probe for "default" instead of the "left_ptr", as the latter is no longer available in Adwaita. Keep the fallback to "left_ptr" for more conservative themes. [1]: https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/commit/74e9b79471236320d2af4925d6c5bb7df22380ce
3fbb2df to
ccc8540
Compare
|
I was wondering if it isn't better to first check for left_ptr and use default as a fallback. Because I was searching around and SDL checks first for left_ptr. |
|
Doesn't really matter, I've seen both orders in major projects, and some projects don't even have a fallback to |
|
Thanks for the information, I'll merge the pr 👍🏻 Also, sorry to bother you but I am not really familiar with the wayland output. Do you know if/how to support for transparent colors in wayland? Is it already working? |
It works if you specify the colors in RGBA format. E.g. |
Adwaita, the default icon theme for many distributions, decided to stop providing legacy Xcursor icons in favor of the GTK/CSS names1. This requires us to probe for "default" instead of the "left_ptr", as the latter is no longer available in Adwaita.
Keep the fallback to "left_ptr" for more conservative themes.