Skip to content

Fix settings initialization#1299

Merged
bynect merged 1 commit intodunst-project:masterfrom
bynect:fix-settings
Apr 6, 2024
Merged

Fix settings initialization#1299
bynect merged 1 commit intodunst-project:masterfrom
bynect:fix-settings

Conversation

@bynect
Copy link
Copy Markdown
Contributor

@bynect bynect commented Mar 1, 2024

settings.print_notifications and settings.startup_notification were always set to zero by load_settings

@bynect bynect requested a review from zappolowski March 1, 2024 22:39
@bynect bynect force-pushed the fix-settings branch 2 times, most recently from 24f6c56 to 83ec20b Compare March 1, 2024 22:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.06%. Comparing base (15b1e8c) to head (53ada2a).
⚠️ Report is 320 commits behind head on master.

Files with missing lines Patch % Lines
src/dunst.c 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1299   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files          48       48           
  Lines        8173     8173           
=======================================
  Hits         5318     5318           
  Misses       2855     2855           
Flag Coverage Δ
unittests 65.06% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zappolowski
Copy link
Copy Markdown
Member

Please rebase to current master to pick up the new actions.

@bynect
Copy link
Copy Markdown
Contributor Author

bynect commented Apr 6, 2024

I'll merge this

@bynect bynect merged commit 1ddbfe2 into dunst-project:master Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants