Skip to content

Don't search for icon path if icons are disabled#1301

Merged
bynect merged 1 commit intodunst-project:masterfrom
bynect:fix-icon-disabled
Apr 6, 2024
Merged

Don't search for icon path if icons are disabled#1301
bynect merged 1 commit intodunst-project:masterfrom
bynect:fix-icon-disabled

Conversation

@bynect
Copy link
Copy Markdown
Contributor

@bynect bynect commented Mar 1, 2024

Close #1114

@bynect bynect requested a review from zappolowski March 1, 2024 23:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.06%. Comparing base (15b1e8c) to head (8ca7f8e).
⚠️ Report is 376 commits behind head on master.

Files with missing lines Patch % Lines
src/notification.c 75.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1301   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files          48       48           
  Lines        8173     8173           
=======================================
  Hits         5318     5318           
  Misses       2855     2855           
Flag Coverage Δ
unittests 65.06% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bynect bynect changed the title Don't search for icon path is icons are disabled Don't search for icon path if icons are disabled Mar 1, 2024
@bynect bynect force-pushed the fix-icon-disabled branch from 917c8bf to ef7570d Compare March 1, 2024 23:49
@bynect
Copy link
Copy Markdown
Contributor Author

bynect commented Mar 4, 2024

This should work unless you can enable icons to an old notification with disabled icons. Because at that point the notification wouldn't have loaded the icon. However I don't think there is a way to change icon_position between creation and display (?)

Comment thread src/queues.c
Comment thread src/notification.c Outdated
Copy link
Copy Markdown
Member

@zappolowski zappolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to current master and squash the 2nd commit into the first one.

@bynect bynect force-pushed the fix-icon-disabled branch from 8d6e543 to 8ca7f8e Compare April 6, 2024 20:23
@bynect bynect merged commit 2e5884f into dunst-project:master Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dunst: Attempts to find icons even when disabled

3 participants