Skip to content

Add printf null checks#1323

Merged
bynect merged 1 commit into
dunst-project:masterfrom
bynect:fix-printf-null
Apr 7, 2024
Merged

Add printf null checks#1323
bynect merged 1 commit into
dunst-project:masterfrom
bynect:fix-printf-null

Conversation

@bynect

@bynect bynect commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Should fix #1305 . I added the null check to the places where a null string could occur. I may have missed some.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 65.06%. Comparing base (764c382) to head (c70459c).

Files Patch % Lines
src/notification.c 0.00% 14 Missing ⚠️
src/icon.c 33.33% 2 Missing ⚠️
src/queues.c 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1323   +/-   ##
=======================================
  Coverage   65.06%   65.06%           
=======================================
  Files          48       48           
  Lines        8173     8173           
=======================================
  Hits         5318     5318           
  Misses       2855     2855           
Flag Coverage Δ
unittests 65.06% <34.61%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect force-pushed the fix-printf-null branch from c70459c to 424b544 Compare April 7, 2024 20:04
@bynect

bynect commented Apr 7, 2024

Copy link
Copy Markdown
Contributor Author

rebased

@bynect bynect merged commit 68100e8 into dunst-project:master Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NULL pointers passed to *printf

3 participants