Skip to content

Add test for DBus RuleEnable and fix memory leak#1328

Merged
zappolowski merged 1 commit into
dunst-project:masterfrom
zappolowski:add-tests-for-rule-enable
Apr 14, 2024
Merged

Add test for DBus RuleEnable and fix memory leak#1328
zappolowski merged 1 commit into
dunst-project:masterfrom
zappolowski:add-tests-for-rule-enable

Conversation

@zappolowski
Copy link
Copy Markdown
Member

This is mainly done to test whether the current pipeline works properly in terms of coverage reporting.

A nice side-effect is, that I could increase the test coverage a bit and fixed a memory leak while doing so.

@zappolowski zappolowski force-pushed the add-tests-for-rule-enable branch from 7123a61 to 38b794c Compare April 8, 2024 18:57
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.98%. Comparing base (07b68f0) to head (38b794c).
⚠️ Report is 351 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
+ Coverage   65.71%   65.98%   +0.27%     
==========================================
  Files          50       50              
  Lines        8041     8056      +15     
  Branches      925      925              
==========================================
+ Hits         5284     5316      +32     
+ Misses       2757     2740      -17     
Flag Coverage Δ
unittests 65.98% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zappolowski zappolowski requested a review from bynect April 11, 2024 05:26
@bynect
Copy link
Copy Markdown
Contributor

bynect commented Apr 12, 2024

can I merge it ?

@zappolowski zappolowski merged commit 5871b0c into dunst-project:master Apr 14, 2024
@zappolowski zappolowski deleted the add-tests-for-rule-enable branch April 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants