Remove default icons and refactor icon-lookup#1365
Merged
bynect merged 3 commits intodunst-project:masterfrom Jul 15, 2024
Merged
Remove default icons and refactor icon-lookup#1365bynect merged 3 commits intodunst-project:masterfrom
bynect merged 3 commits intodunst-project:masterfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
- Coverage 66.08% 66.07% -0.01%
==========================================
Files 50 50
Lines 8247 8228 -19
Branches 965 966 +1
==========================================
- Hits 5450 5437 -13
+ Misses 2797 2791 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
some cleanup |
fwsmit
reviewed
Jul 2, 2024
bynect
changed the title
Contributor
Author
|
@fwsmit does it looks good? can I merge? |
Member
Yeah, looks good. You can go ahead and merge |
fwsmit
approved these changes
Jul 14, 2024
Contributor
Author
perfect 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by #1364 and #1358. I also refactored the search function to provide more informative logging