Skip to content

Add more signals - #1405

Merged
bynect merged 3 commits into
dunst-project:masterfrom
bynect:more-signal
Feb 25, 2025
Merged

Add more signals#1405
bynect merged 3 commits into
dunst-project:masterfrom
bynect:more-signal

Conversation

@bynect

@bynect bynect commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Add the signal requested by #1277 and some more

@codecov-commenter

codecov-commenter commented Dec 4, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.91781% with 41 lines in your changes missing coverage. Please review.

Project coverage is 65.58%. Comparing base (73c7f92) to head (884fad3).
Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
test/dbus.c 77.57% 24 Missing ⚠️
src/dbus.c 52.77% 17 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   65.32%   65.58%   +0.26%     
==========================================
  Files          50       50              
  Lines        8763     8905     +142     
  Branches     1034     1041       +7     
==========================================
+ Hits         5724     5840     +116     
- Misses       3039     3065      +26     
Flag Coverage Δ
unittests 65.58% <71.91%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bynect

bynect commented Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

I need to add some tests

@fwsmit fwsmit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Adding some tests is a good idea, yeah.

@bynect bynect linked an issue Dec 11, 2024 that may be closed by this pull request
@bynect
bynect marked this pull request as ready for review February 25, 2025 20:58
@bynect
bynect merged commit a0dbc00 into dunst-project:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dunsctl history-pop and history-rm doesn't emit a signal?

3 participants