Add backward compatibility for height + notice#1412
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 65.12% 65.08% -0.04%
==========================================
Files 50 50
Lines 8654 8670 +16
Branches 1023 1025 +2
==========================================
+ Hits 5636 5643 +7
- Misses 3018 3027 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you for making the change for compatibility. I agree with the users that making the configuration backward compatible is very important. I would even suggest to keep the current configuration working for version 2, since it would cause a lot of work for users to move their configuration over to the new version. Instead you could maybe add a version specifier to the configuration file like "#dunst config V2" and only fix the inconsistencies there. |
well, if there are some backward incompatible changes to be made it has to be a major revision. |
|
Thank you for making this change! This will save time for many users, I expect :) |
Well see yeah. For now i think its good to just bring a new release with these fixes |
I want to fix one last thing than I can make 12.1 |
As solicited by @stapelberg in the discussions this will be a (temporary) solution for backward compatibility of
height.This will not make it into v2, but for now is fine.
I will need to release a 1.12.1 anyway due to the graphical bug #1406