Skip to content

Fix memory corruption when reloading - #1413

Merged
bynect merged 4 commits into
dunst-project:masterfrom
bynect:fix-gradient
Dec 14, 2024
Merged

Fix memory corruption when reloading#1413
bynect merged 4 commits into
dunst-project:masterfrom
bynect:fix-gradient

Conversation

@bynect

@bynect bynect commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

Caused occasional double frees

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.07%. Comparing base (162fc27) to head (1b37ab5).

Files with missing lines Patch % Lines
src/option_parser.c 42.85% 4 Missing ⚠️
src/dunst.c 0.00% 1 Missing ⚠️
src/rules.c 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
- Coverage   65.12%   65.07%   -0.05%     
==========================================
  Files          50       50              
  Lines        8654     8659       +5     
  Branches     1023     1025       +2     
==========================================
- Hits         5636     5635       -1     
- Misses       3018     3024       +6     
Flag Coverage Δ
unittests 65.07% <40.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect
bynect marked this pull request as draft December 10, 2024 14:01
@bynect
bynect marked this pull request as ready for review December 13, 2024 23:40
@bynect

bynect commented Dec 13, 2024

Copy link
Copy Markdown
Contributor Author

@fwsmit when debugging some double frees I noticed that rules where not cleaned up when reloading. so I changed it to remove all old rules. which should be the best thing to do right?

@bynect bynect changed the title Fix gradient ownership in rule Fix memory corruption when reloading Dec 13, 2024
@bynect

bynect commented Dec 14, 2024

Copy link
Copy Markdown
Contributor Author

strange codecov error unrelated to code

@bynect
bynect merged commit 75c2305 into dunst-project:master Dec 14, 2024
@fwsmit

fwsmit commented Dec 14, 2024

Copy link
Copy Markdown
Member

Yeah, rules from an old config should be removed

@bynect

bynect commented Dec 14, 2024

Copy link
Copy Markdown
Contributor Author

Yeah, rules from an old config should be removed

@fwsmit can i make the release now?

@fwsmit

fwsmit commented Dec 15, 2024

Copy link
Copy Markdown
Member

Yeah, go ahead 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants