Fix memory corruption when reloading - #1413
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
- Coverage 65.12% 65.07% -0.05%
==========================================
Files 50 50
Lines 8654 8659 +5
Branches 1023 1025 +2
==========================================
- Hits 5636 5635 -1
- Misses 3018 3024 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@fwsmit when debugging some double frees I noticed that rules where not cleaned up when reloading. so I changed it to remove all old rules. which should be the best thing to do right? |
|
strange codecov error unrelated to code |
|
Yeah, rules from an old config should be removed |
@fwsmit can i make the release now? |
|
Yeah, go ahead 👍 |
Caused occasional double frees