Skip to content

Allow to override build date with SOURCE_DATE_EPOCH#1435

Merged
bynect merged 1 commit into
dunst-project:masterfrom
bmwiedemann:master
Jan 29, 2025
Merged

Allow to override build date with SOURCE_DATE_EPOCH#1435
bynect merged 1 commit into
dunst-project:masterfrom
bmwiedemann:master

Conversation

@bmwiedemann

@bmwiedemann bmwiedemann commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Allow to override build date with SOURCE_DATE_EPOCH to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call works with different flavors of date (GNU, BSD, other).
Alternatively the date could be dropped completely to simplify the code.

This patch was done while working on reproducible builds for openSUSE.

@codecov-commenter

codecov-commenter commented Jan 22, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (1827713) to head (bd93270).
Report is 85 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          50       50           
  Lines        8763     8763           
  Branches     1034     1034           
=======================================
  Hits         5724     5724           
  Misses       3039     3039           
Flag Coverage Δ
unittests 65.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bynect

bynect commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

The date is not really necessary but it was nice to have.

I understand the need for reproducible builds, so I approve these changes.

If possible I would like to keep support for BSD.

to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This date call works with different flavors of date (GNU, BSD, other).

This patch was done while working on reproducible builds for openSUSE.
@bmwiedemann

Copy link
Copy Markdown
Contributor Author

I updated the patch to also support BSD.

@bynect bynect merged commit fe7f928 into dunst-project:master Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants