makefile: add version variable quotes in git case - #1456
Merged
Conversation
Add quotes to the VERSION variable, when they are determined by invoking git. While git describe doesn't seem to output spaces. But the fallback case of just echoing the VERSION variable may contain spaces, as every release includes a space separated release date in the version variable. This fixes the issue that if the .git directory is present on a release, but the git command isn't available or fails, the VERSION variable isn't escaped anymore and the release date contained causes a build failure.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
==========================================
- Coverage 65.60% 65.57% -0.03%
==========================================
Files 50 50
Lines 8910 8910
Branches 1044 1043 -1
==========================================
- Hits 5845 5843 -2
- Misses 3065 3067 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add quotes to the VERSION variable, when they are determined by invoking git. git describe doesn't seem to output spaces. But the fallback case of just echoing the VERSION variable may contain spaces, as every release includes a space separated release date in the version variable.
This fixes the issue that if the .git directory is present on a release, but the git command isn't available or fails, the VERSION variable isn't escaped anymore and the release date contained causes a build failure.