Skip to content

parse raw icons from the (deprecated) image_data attribute#353

Merged
tsipinakis merged 1 commit into
dunst-project:masterfrom
sfs:raw-icon-from-image_data
Aug 9, 2017
Merged

parse raw icons from the (deprecated) image_data attribute#353
tsipinakis merged 1 commit into
dunst-project:masterfrom
sfs:raw-icon-from-image_data

Conversation

@sfs
Copy link
Copy Markdown
Contributor

@sfs sfs commented Aug 6, 2017

The desktop notification spec version 1.1 used "image_data" instead of "image-data" as the key for raw icons. This is still used in some applications, e.g., in the Clementine music player.

@bebehei
Copy link
Copy Markdown
Member

bebehei commented Aug 7, 2017

What about fixing it there, too?

@sfs
Copy link
Copy Markdown
Contributor Author

sfs commented Aug 7, 2017

I did submit a PR to Clementine, but I'm using a non-standard branch. Not sure how useful this will be.

@tsipinakis
Copy link
Copy Markdown
Member

tsipinakis commented Aug 9, 2017

I did submit a PR to Clementine, but I'm using a non-standard branch. Not sure how useful this will be.

Looks like your PR got rejected since the maintainer doesn't want to merge fixes into that branch. I'd recommend at least filing an issue about it to server as a reminder.


The notification spec doesn't say anything about where image_data should be in the priority list, but assuming it's equivalent to image-data I'm merging this as is but might change the priority if it starts causing problems.

Thank you!

@tsipinakis tsipinakis merged commit 68aa1f2 into dunst-project:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants