New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort linker input file list #372

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@bmwiedemann
Contributor

bmwiedemann commented Sep 12, 2017

so that dunst binaries build in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

Note: the same change could be applied to the test/test part
but that does not end up in the (openSUSE) package so does not matter as much.

Sort linker input file list
so that dunst binaries build in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

@tsipinakis tsipinakis merged commit 2acc4be into dunst-project:master Sep 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bebehei

This comment has been minimized.

Show comment
Hide comment
@bebehei

bebehei Sep 13, 2017

Member

@bmwiedemann This should be everything to make dunst fully reproducible? Really? I can't believe this!

Member

bebehei commented Sep 13, 2017

@bmwiedemann This should be everything to make dunst fully reproducible? Really? I can't believe this!

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 13, 2017

Contributor

Actually it is (at least for openSUSE where we have a normalized build environment with constant user, build-path, timezone). And maybe because we have helpful patches in other places like gcc and rpm that override macros like __DATE__

Contributor

bmwiedemann commented Sep 13, 2017

Actually it is (at least for openSUSE where we have a normalized build environment with constant user, build-path, timezone). And maybe because we have helpful patches in other places like gcc and rpm that override macros like __DATE__

@bebehei

This comment has been minimized.

Show comment
Hide comment
@bebehei

bebehei Sep 13, 2017

Member

Wow!

Member

bebehei commented Sep 13, 2017

Wow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment