Skip to content

Support image-path hint#447

Merged
bebehei merged 1 commit intodunst-project:masterfrom
bebehei:image-path
Nov 25, 2017
Merged

Support image-path hint#447
bebehei merged 1 commit intodunst-project:masterfrom
bebehei:image-path

Conversation

@bebehei
Copy link
Copy Markdown
Member

@bebehei bebehei commented Nov 24, 2017

As GApplications expose their icon via image-path hint and not via the
actual app_icon field, GApplication icons haven't been displayed before.

According to the notification spec, image-path hint should also override
the app_icon as follows:

  1. image-data hint
  2. image-path hint
  3. app_icon parameter

As GApplications expose their icon via image-path hint and not via the
actual app_icon field, GApplication icons haven't been displayed before.

According to the notification spec, image-path hint should also override
the app_icon as follows:

1. image-data hint
2. image-path hint
3. app_icon parameter
@bebehei bebehei added this to the v1.3.0 milestone Nov 24, 2017
@bebehei bebehei requested a review from tsipinakis November 24, 2017 23:31
@bebehei
Copy link
Copy Markdown
Member Author

bebehei commented Nov 24, 2017

Fixes #446

Copy link
Copy Markdown
Member

@tsipinakis tsipinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The priorities are a bit backwards here. In x.c the raw icon always takes priority over the path but that's not how it is in the specification:

  • image-data (raw icon)
  • image-path (icon)
  • app_icon (icon)
  • icon_data (raw icon)

Copy link
Copy Markdown
Member

@tsipinakis tsipinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just realized that this also affects the current master and is thus out of scope for this, I'll approve this but we should handle this point too.

@bebehei
Copy link
Copy Markdown
Member Author

bebehei commented Nov 25, 2017

The priorities are a bit backwards here. In x.c the raw icon always takes priority over the path but that's not how it is in the specification

Except for icon_data, we handle everything right. IMHO it's ok to "ignore" the spec here and care about more important things.

@bebehei bebehei merged commit 714731e into dunst-project:master Nov 25, 2017
@bebehei bebehei mentioned this pull request Nov 25, 2017
@bebehei bebehei deleted the image-path branch November 26, 2017 14:16
karlicoss pushed a commit to karlicoss/dunst that referenced this pull request Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants