Merged
Conversation
As GApplications expose their icon via image-path hint and not via the actual app_icon field, GApplication icons haven't been displayed before. According to the notification spec, image-path hint should also override the app_icon as follows: 1. image-data hint 2. image-path hint 3. app_icon parameter
Member
Author
|
Fixes #446 |
tsipinakis
requested changes
Nov 25, 2017
tsipinakis
approved these changes
Nov 25, 2017
Member
tsipinakis
left a comment
There was a problem hiding this comment.
I've just realized that this also affects the current master and is thus out of scope for this, I'll approve this but we should handle this point too.
Member
Author
Except for |
Closed
karlicoss
pushed a commit
to karlicoss/dunst
that referenced
this pull request
Mar 21, 2019
Support image-path hint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As GApplications expose their icon via image-path hint and not via the
actual app_icon field, GApplication icons haven't been displayed before.
According to the notification spec, image-path hint should also override
the app_icon as follows: