Makefile: correct dependencies to fix race condition#488
Merged
tsipinakis merged 1 commit intodunst-project:masterfrom Jan 30, 2018
Merged
Makefile: correct dependencies to fix race condition#488tsipinakis merged 1 commit intodunst-project:masterfrom
tsipinakis merged 1 commit intodunst-project:masterfrom
Conversation
Before this commit, when building dunst in parallel, org.knopwob.dunst.service might get installed as an empty file. See https://bugs.debian.org/888760
bebehei
approved these changes
Jan 29, 2018
Member
bebehei
left a comment
bebehei
left a comment
There was a problem hiding this comment.
Thank you @stapelberg for these changes. That was totally my fault. The Arch maintainers already complained about the empty dbus file. I couldn't reproduce it on my system. You're awesome, thanks!
Member
|
@tsipinakis I think we should backport and release it as |
Member
|
Thanks for catching this! I agree that this is a serious enough issue to warrant a bugfix release. |
karlicoss
pushed a commit
to karlicoss/dunst
that referenced
this pull request
Mar 21, 2019
Fix race condition resulting in the service file being empty in some cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, when building dunst in parallel, org.knopwob.dunst.service might get installed as an empty file. See https://bugs.debian.org/888760