Skip to content

per section 'frame_color' parameter#498

Merged
tsipinakis merged 1 commit intodunst-project:masterfrom
shizeeg:master
Mar 8, 2018
Merged

per section 'frame_color' parameter#498
tsipinakis merged 1 commit intodunst-project:masterfrom
shizeeg:master

Conversation

@shizeeg
Copy link
Copy Markdown
Contributor

@shizeeg shizeeg commented Mar 8, 2018

make it possible to change frame color on section basis. For example when I receive notifications from twitch.tv I want them to be in twitch color scheme.

@tsipinakis
Copy link
Copy Markdown
Member

tsipinakis commented Mar 8, 2018

Thanks for the contribution! Works as intended.

The manpage has been neglected lately, can you also update the RULES and COLORS/NOTIFY-SEND section of the manpage to mention the new variable?

@shizeeg
Copy link
Copy Markdown
Contributor Author

shizeeg commented Mar 8, 2018

@tsipinakis oops, totally forget about that, done. Should I merge my pull request into one commit & reopen it?

@tsipinakis
Copy link
Copy Markdown
Member

There is no need to reopen the PR, just squash the commits.

git rebase -i HEAD~2

Change the first word on the second commit to fixup (aka merge with the previous commit)

and git push --force

@shizeeg
Copy link
Copy Markdown
Contributor Author

shizeeg commented Mar 8, 2018

thanks for your help. Done.

@tsipinakis
Copy link
Copy Markdown
Member

Thank you for your work.

(Not sure what's up with coveralls, it's been failing randomly lately -.- )

@tsipinakis tsipinakis merged commit d536ae7 into dunst-project:master Mar 8, 2018
@tsipinakis tsipinakis added this to the v1.4.0 milestone Feb 15, 2019
karlicoss pushed a commit to karlicoss/dunst that referenced this pull request Mar 21, 2019
per section 'frame_color' parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants