Concatenated queues#541
Merged
Merged
Conversation
bebehei
force-pushed
the
concatenated-queues
branch
from
f8113b7 to
8b16ef5
Compare
Member
Author
Member
Author
|
@tsipinakis I'd love to see your review 😉 |
Member
|
Sorry, I've tried to review this twice already but both times there's something bothering me with the way this is implemented but at the same time I can't think of a better way to do it. I'll look into it more tomorrow. |
tsipinakis
reviewed
Sep 11, 2018
tsipinakis
reviewed
Sep 11, 2018
Member
|
Somehow I submitted the review before I was actually done, oops! Works fine from what I can tell, so my nitpicks this time are about simplifying the code :p |
bebehei
commented
Sep 12, 2018
bebehei
force-pushed
the
concatenated-queues
branch
2 times, most recently
from
464e76a to
a296581
Compare
When the display queue had is full and a new notification would come in, new notification wouldn't get shown until a currently displayed notification would timeout. Even if the notification would have been shown on top of the displayed queue. So e.g. if the displayed queue would have been filled with "normal" urgency notifications, an incoming "urgent" notification would have been delayed. To let those more important notifications through, the tail of displayed and head of waiting are swapped on every update if necessary.
bebehei
force-pushed
the
concatenated-queues
branch
from
a296581 to
60bc134
Compare
For the case, that there is a single notification waiting in queue, the xmore layout is an annoying setting.
Using the last notification from displayed creates confusion about nonexisting notifications.
bebehei
force-pushed
the
concatenated-queues
branch
3 times, most recently
from
c76c254 to
97434f0
Compare
Member
Author
|
@tsipinakis I've simplyfied the code now and polished the commits. I'd consider it final now. A review would be great! Thanks! |
tsipinakis
reviewed
Sep 14, 2018
On actions, where waiting and displayed has to get traversed, traverse them both in a single loop. Code duplication isn't necessary anymore.
bebehei
force-pushed
the
concatenated-queues
branch
from
97434f0 to
e1ee87b
Compare
tsipinakis
approved these changes
Sep 14, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let important notifications seep into displayed even if the
displayqueue is full.By checking the joint of both queues, if you concatenate now the
waitinganddisplayqueues, the concatenated queue is still sorted. A push to waiting andqueues_update()should show the important notifications even if there if display is full.Previously, this would have required a timeout of a notification in the displayed queue. Now it works immediately.
Fixes #431
Fixes #467