Misc patches#550
Merged
Merged
Conversation
The blame reveals commit 820cfe7, which introduced printing of notifications similar to notification_print(). The fflush call is still left over since porting the printfs into their dedicated method. As notification_print() is called after this fflush() call, it's not necessary anymore.
tsipinakis
requested changes
Oct 2, 2018
tsipinakis
requested changes
Oct 3, 2018
Member
tsipinakis
left a comment
tsipinakis
left a comment
There was a problem hiding this comment.
Missed a few stuff, and found some more in the meantime!
GLib's g_get_user_config_dir function does exactly the same thing and we don't need libxdg-basedir for something else.
bebehei
force-pushed
the
misc
branch
2 times, most recently
from
d1575f8 to
1c61106
Compare
tsipinakis
previously approved these changes
Oct 6, 2018
And also use g_strndup. This makes allocation easier and also ensures a null-byte at the end of the string.
bebehei
force-pushed
the
misc
branch
2 times, most recently
from
47c40f4 to
61657a8
Compare
tsipinakis
reviewed
Oct 9, 2018
Output first, then all required objects and then the FLAGS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some miscellaneous changes, accumulated over the past weeks.
TBH, the libxdg removal came out of the blue. I found out today about the
g_get_user_config_dirfunction, which makeslibxdg-basedirirrelevant.