Implement a command line control (dunstctl) by bebehei · Pull Request #651 · dunst-project/dunst

bebehei · 2019-08-11T13:45:15Z

Work in progress, I expect to be finish & polish it during the next week.

Fixes:

TODO:

Rewrite the commit messages
test in dunstctl, if we're actually speaking with a compatible dunst instance
add a debug subcommand to dunstctl to support debugging later.

Stunkymonkey

testing the cl-interface everything works fine.

Stunkymonkey · 2019-09-16T21:32:19Z

+		method_call "${DBUS_IFAC_DUNST}.NotificationShow" >/dev/null
+		;;
+	"status")
+		property_get running | ( read _ _ status; printf "%s\n" "${status}"; )


can produce the output if dunst is not running:

$ dunstctl status Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.

is this wanted?

Stunkymonkey · 2019-09-16T21:33:17Z

+			|| die "No status parameter specified. Please give either 'true' or 'false' as running parameter."
+		[ "${2}" == "true" ] || [ "${2}" == "false" ] \
+			|| die "Please give either 'true' or 'false' as running parameter."
+		property_set running variant:boolean:"${2}"


the same applies here from above

Stunkymonkey · 2019-09-17T14:03:53Z

+    "    <interface name=\""DUNST_IFAC"\">"
+
+    "        <method name=\"ContextMenuCall\"       />"
+// TODO: add an optional parmater definining the action of notification number X to invoke


i skipped reading through this file, because there are too much TODOs and FIXMEs.
but testing wise, everything works perfectly fine for me.

tsipinakis · 2020-04-04T11:02:58Z

@bebehei Looking at the TODOs in the first message this looks almost done, will you work on it or maybe I should take over? I'd like to finish this and make a release soon-ish.

Stunkymonkey · 2020-04-04T11:49:09Z

when continuing, also look at this: bebehei#2

bebehei · 2020-04-04T12:47:05Z

@tsipinakis Well, sad news. @Stunkymonkey and I started a new project together and our goal is to rewrite dunst in Rust. You may have seen it already in your GitHub timeline, it's called durst (german for thirst and a funny combination of dunst and rust).

Beginning with the lockdown for the corona pandemic, I've got more time to contribute to OSS projects again. In relation to the durst notification manager, I'll continue to help here in dunst. But my long term goal will be the switch to durst.

So yes, I won't finish this PR here in its full intention. Feel free to clone the branch and continue (or start over and rewrite commits). I won't have the necessary power and motivation to finish this PR.

bebehei · 2020-04-04T12:48:09Z

PS: If you want to join the project, we'd be happy to have you there.

tsipinakis · 2020-04-04T13:42:35Z

Well, sad news. @Stunkymonkey and I started a new project together and our goal is to rewrite dunst in Rust

I saw you creating the repo, but at the time it was just a hello world. I'll post some of my thoughts in an issue in that repo later today :)

tsipinakis · 2020-04-09T18:05:09Z

@bebehei Mind giving this a review? I completed pretty much everything still in progress I could find, and scrapped the monitor for status changes features for now. It will probably take some effort and I'll return to it later.
For now my goal is to get at least a replacement for the keyboard shortcuts merged ASAP.

codecov-io · 2020-04-10T08:46:09Z

Codecov Report

Merging #651 into master will decrease coverage by 0.10%.
The diff coverage is 15.18%.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   66.40%   66.29%   -0.11%     
==========================================
  Files          29       29              
  Lines        4899     5076     +177     
==========================================
+ Hits         3253     3365     +112     
- Misses       1646     1711      +65

Flag	Coverage Δ
#unittests	`66.29% <15.18%> (-0.11%)`	⬇️

Impacted Files	Coverage Δ
test/dunst.c	`78.57% <0.00%> (-21.43%)`	⬇️
src/dbus.c	`66.54% <13.51%> (-19.37%)`	⬇️
test/dbus.c	`98.67% <100.00%> (+<0.01%)`	⬆️
src/x11/x.c	`2.33% <0.00%> (-0.02%)`	⬇️
src/option_parser.c	`86.66% <0.00%> (+0.38%)`	⬆️
test/option_parser.c	`98.25% <0.00%> (+0.53%)`	⬆️
src/utils.c	`91.59% <0.00%> (+0.94%)`	⬆️
src/settings.c	`57.89% <0.00%> (+1.27%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d03802...c89898b. Read the comment docs.

bebehei · 2020-04-10T09:00:55Z

I'll review this now.

bebehei

Shall I review my own code, too?

tsipinakis · 2020-04-10T10:31:23Z

Fixed.

Shall I review my own code, too?

Of course 😉

As suggested in dunst-project/dunst#216 (comment). /tmp should be cleared on boot. Note that notifications is still turned on when starting i3. That way we override whatever the default behaviour of dunst is (it defaults to on) and we force the state to appear in i3status by creating the state file. This is fine while waiting for dunstctl (dunst-project/dunst#651).

tsipinakis · 2020-04-14T18:08:07Z

I'm basically done here I think.
@bebehei Tell me if you want to focus on durst rather than reviewing PRs here, but mind a final review?

`==` is not supported in plain sh

tsipinakis · 2020-05-01T13:38:18Z

I timed out waiting for @bebehei, I'll just merge this for now to have something usable in master. Any other fixes can be done later.

I'd like to see this tested for some weeks before making a release, if you do use it please report your experience with it and any bugs you find.

AkashKrDutta · 2021-05-16T17:32:51Z

Hi. This PR doesn't resolve #308 right? The history-pop command just re-displays the notifications from history and they again go back to the history stack after click/timeout. let me know if there's a command to remove a notification from history.

fwsmit · 2021-05-16T17:40:17Z

No you're right. I do not plan on implementing that feature any time soon, but you could implement it yourself. Otherwise, subscribe to the issue and you'll hear when it's implemented

BachoSeven · 2021-07-25T10:43:31Z

@fwsmit So if I understand correctly now all keybindings from [shortcuts], which was just deprecated by your PR, need to be implemented manually by users through their WMs by using dunstctl commands(?)

fwsmit · 2021-07-25T11:15:53Z

@fwsmit So if I understand correctly now all keybindings from [shortcuts], which was just deprecated by your PR, need to be implemented manually by users through their WMs by using dunstctl commands(?)

Yes. There was already a warning in the documentation about the shortcuts section being deprecated for a while now. All settings in the [shortcuts] section should have dunstctl equivalents.

BachoSeven · 2021-07-25T11:22:26Z

I see, thanks for the clarification. I ran dunst via .xinitrc and didn't notice the deprecation messages until today when the shortcuts stopped working :'D

bebehei added the Feature label Aug 11, 2019

bebehei added this to the 1.5 milestone Aug 11, 2019

bebehei force-pushed the dunstctl branch from 3366305 to e594be6 Compare August 11, 2019 13:45

bebehei mentioned this pull request Aug 19, 2019

Expose do_action as a keyboard shortcut #655

Closed

bebehei force-pushed the dunstctl branch 2 times, most recently from d079bad to ad848be Compare August 23, 2019 00:15

bebehei changed the title ~~Implement a command line control~~ Implement a command line control (dunstctl) Aug 23, 2019

Stunkymonkey reviewed Sep 17, 2019

View reviewed changes

tsipinakis mentioned this pull request Nov 1, 2019

Default history key binding clashes with VSCode #670

Closed

tsipinakis mentioned this pull request Feb 17, 2020

signal to reload dunstrc #63

Closed

tsipinakis mentioned this pull request Apr 3, 2020

Install dunstify #701

Merged

tsipinakis marked this pull request as ready for review April 9, 2020 18:03

bebehei and others added 5 commits April 10, 2020 10:47

Add DBus interface to control dunst

55f4971

Add dunstctl shell script

305ab6c

Overhaul dunstctl

72d68fc

Install dunstctl via make automatically

e80e8e9

Add debug command

a3342d0

tsipinakis force-pushed the dunstctl branch from 391d55c to c89898b Compare April 10, 2020 08:49

bebehei commented Apr 10, 2020

View reviewed changes

Comment thread src/dbus.c

Comment thread dunstctl Outdated

Comment thread dunstctl Outdated

Comment thread dunstctl Outdated

Comment thread dunstctl Outdated

tsipinakis added 14 commits May 1, 2020 15:35

dunstctl: Use = rather than == for string equality

6a8401d

`==` is not supported in plain sh

dunstctl: Apply shellcheck suggestions

e14160b

Wake up after changing status via dunstctl

b1f64b2

dunstctl: Print help message on dbus communication failure

936dbb0

Don't wake up after doing an action

ee11dfa

Remove live status checking (for now)

9049bf1

Properly handle error conditions from dunstctl

ec421f1

dunstctl: Fix alignment in help message

36eed78

Implement error handling in NotificationAction call

a91adf9

Use set -e

23fa204

Fix dunstctl help alignment

94aa427

Rename status commands to running

5aa1863

Add dunstctl man page

6ba430a

Mention dunstctl in dunst man page

50a55f2

tsipinakis force-pushed the dunstctl branch from fd4a4db to 50a55f2 Compare May 1, 2020 13:35

tsipinakis merged commit 337ff1e into dunst-project:master May 1, 2020

mrossinek mentioned this pull request May 1, 2020

Allow toggle paused status via dunstctl #709

Closed

Conversation

bebehei commented Aug 11, 2019

Fixes:

TODO:

Uh oh!

Stunkymonkey left a comment

Choose a reason for hiding this comment

Uh oh!

Stunkymonkey Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

Stunkymonkey Sep 16, 2019

Choose a reason for hiding this comment

Uh oh!

Stunkymonkey Sep 17, 2019

Choose a reason for hiding this comment

Uh oh!

tsipinakis commented Apr 4, 2020

Uh oh!

Stunkymonkey commented Apr 4, 2020

Uh oh!

bebehei commented Apr 4, 2020

Uh oh!

bebehei commented Apr 4, 2020

Uh oh!

tsipinakis commented Apr 4, 2020

Uh oh!

tsipinakis commented Apr 9, 2020

Uh oh!

codecov-io commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bebehei commented Apr 10, 2020

Uh oh!

bebehei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tsipinakis commented Apr 10, 2020

Uh oh!

tsipinakis commented Apr 14, 2020

Uh oh!

tsipinakis commented May 1, 2020

Uh oh!

AkashKrDutta commented May 16, 2021

Uh oh!

fwsmit commented May 16, 2021

Uh oh!

BachoSeven commented Jul 25, 2021

Uh oh!

fwsmit commented Jul 25, 2021

Uh oh!

BachoSeven commented Jul 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov-io commented Apr 10, 2020 •

edited

Loading